Skip to content

docs(jans-cedarling): add per-language getting started examples #11205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
May 15, 2025

Conversation

rmarinn
Copy link
Contributor

@rmarinn rmarinn commented Apr 9, 2025

Prepare


Description

This PR adds language-specific getting started examples to the docs.

Target issue

closes #11206

Implementation Details


Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

Please check the below before submitting your PR. The PR will not be merged if there are no commits that start with docs: to indicate documentation changes or if the below checklist is not selected.

  • I confirm that there is no impact on the docs due to the code changes in this PR.

Closes #11206,

@mo-auto
Copy link
Member

mo-auto commented Apr 9, 2025

Error: Hi @rmarinn, You did not reference an open issue in your PR. I attempted to create an issue for you.
Please update that issues' title and body and make sure I correctly referenced it in the above PRs body.

@mo-auto mo-auto added area-documentation Documentation needs to change as part of issue or PR comp-docs Touching folder /docs comp-jans-cedarling Touching folder /jans-cedarling labels Apr 9, 2025
@rmarinn
Copy link
Contributor Author

rmarinn commented Apr 9, 2025

@duttarnab i am updating the docs but I am not sure if the snippets for Swift and Kotlin are correct. could you have a look?

@rmarinn rmarinn requested review from olehbozhok and nynymike April 12, 2025 17:42
@rmarinn rmarinn force-pushed the jans-cedarling-per-lang-examples branch from b5cfa7b to bbc3988 Compare April 14, 2025 09:08

```swift
let cedarling = try Cedarling.loadFromJson(config: "...")
```

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Java should be ready for docs. Ask @uprightech . Go is just getting started, but we may want to put a placeholder in the docs for this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added a placeholder for Go in this commit: ae04138

"CEDARLING_LOG_TYPE": "std_out",
"CEDARLING_LOG_LEVEL": "DEBUG",
"CEDARLING_USER_AUTHZ": "enabled",
"CEDARLING_WORKLOAD_AUTHZ": "disabled",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to list the disabled claims?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need to set the disabled explicitly as it defaults to disabled but i thought it would be a good idea to add those for convenience (like to toggle JWT signature validation) and to hint that they exist.

olehbozhok
olehbozhok previously approved these changes Apr 15, 2025
@rmarinn rmarinn force-pushed the jans-cedarling-per-lang-examples branch from 2d30a33 to ffbfbbd Compare April 21, 2025 03:03
@rmarinn rmarinn marked this pull request as ready for review April 21, 2025 03:04
@rmarinn rmarinn requested review from olehbozhok and SafinWasi April 21, 2025 03:04
@rmarinn rmarinn enabled auto-merge (squash) April 21, 2025 03:06
olehbozhok
olehbozhok previously approved these changes Apr 21, 2025
SafinWasi
SafinWasi previously approved these changes May 1, 2025
duttarnab
duttarnab previously approved these changes May 8, 2025
Copy link
Contributor

@SafinWasi SafinWasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a few fixes. Are we doing the kotlin and swift pages separately from this PR?

@rmarinn
Copy link
Contributor Author

rmarinn commented May 10, 2025

Are we doing the kotlin and swift pages separately from this PR?

Yes

@rmarinn rmarinn requested review from SafinWasi and duttarnab May 10, 2025 06:48
SafinWasi
SafinWasi previously approved these changes May 12, 2025
SafinWasi
SafinWasi previously approved these changes May 13, 2025
@moabu moabu disabled auto-merge May 15, 2025 17:35
@moabu moabu merged commit ce27cb5 into main May 15, 2025
2 checks passed
@moabu moabu deleted the jans-cedarling-per-lang-examples branch May 15, 2025 17:35
rmarinn added a commit that referenced this pull request May 20, 2025
* docs(cedarling): add per-language example in cedarling-getting-started.md

Signed-off-by: rmarinn <[email protected]>

* docs(cedarling): add per-lang getting started in mkdocs.yml

Signed-off-by: rmarinn <[email protected]>

* docs: add javscript example

Signed-off-by: rmarinn <[email protected]>

* docs: add getting started stub for Go

Signed-off-by: rmarinn <[email protected]>

* docs: update python installation section

Signed-off-by: rmarinn <[email protected]>

* docs: add rust getting started section

Signed-off-by: rmarinn <[email protected]>

* fix: mkdocs.yml formatting

Signed-off-by: rmarinn <[email protected]>

* fix: formatting in cedarling-getting-started.md

Signed-off-by: rmarinn <[email protected]>

* fix: python example and docs

Signed-off-by: rmarinn <[email protected]>

* docs: update getting-started/python.md installation section

Signed-off-by: rmarinn <[email protected]>

* docs: fix typo 'precompile' to 'pre-compiled'

Signed-off-by: rmarinn <[email protected]>

* docs: move overview ahead of the getting started section

Signed-off-by: rmarinn <[email protected]>

* docs: add 'see also' sections in the getting-started docs

Signed-off-by: rmarinn <[email protected]>

* ci: fix sidecar path

Signed-off-by: SafinWasi <[email protected]>

* docs: make cedarling initialization code in kotlin, swift more explanatory

Signed-off-by: duttarnab <[email protected]>

* docs: fix broken links and incorrect grammar

Signed-off-by: rmarinn <[email protected]>

* docs(jans-cedarling): reformat stuff (#11396)

Signed-off-by: SafinWasi <[email protected]>

* docs(jans-cedarling): reformat stuff (#11396)

Signed-off-by: Safin Wasi <[email protected]>

---------

Signed-off-by: rmarinn <[email protected]>
Signed-off-by: SafinWasi <[email protected]>
Signed-off-by: duttarnab <[email protected]>
Signed-off-by: Safin Wasi <[email protected]>
Co-authored-by: SafinWasi <[email protected]>
Co-authored-by: duttarnab <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-documentation Documentation needs to change as part of issue or PR comp-docs Touching folder /docs comp-jans-cedarling Touching folder /jans-cedarling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs(jans-cedarling): add per-language getting started examples
7 participants