Skip to content

Upgrade to Ubuntu 18.04 bionic #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Upgrade to Ubuntu 18.04 bionic #193

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3bac0d6
Upgrade to Ubuntu 18.04 bionic
ishitatsuyuki May 1, 2018
98917f8
Add gpg-agent
ishitatsuyuki May 1, 2018
863f845
Disable interactive configuration
ishitatsuyuki May 1, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions ubuntu-dev/ubuntu-dev.dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,29 +1,26 @@
FROM ubuntu:16.04
FROM ubuntu:18.04

# Install HTTPS transport for Ubuntu package sources.
RUN apt-get update \
&& apt-get install -y --no-install-recommends apt-transport-https ca-certificates software-properties-common \
&& apt-get install -y --no-install-recommends apt-transport-https ca-certificates software-properties-common gpg-agent \
&& rm -rf /var/lib/apt/lists/*

# Add source for the latest Clang packages.
COPY llvm-snapshot.gpg.key /tmp
RUN echo "deb https://apt.llvm.org/xenial/ llvm-toolchain-xenial-6.0 main" > /etc/apt/sources.list.d/llvm.list \
RUN echo "deb https://apt.llvm.org/bionic/ llvm-toolchain-bionic-6.0 main" > /etc/apt/sources.list.d/llvm.list \
&& apt-key add /tmp/llvm-snapshot.gpg.key \
&& rm -f /tmp/llvm-snapshot.gpg.key

# Add source for the latest Git packages.
RUN add-apt-repository ppa:git-core/ppa

# Add source for the latest Mercurial packages.
RUN add-apt-repository ppa:mercurial-ppa/releases
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, this PPA looks badly unmaintained, they still don't support 18.04/bionic (super cool code name by the way!), and their last update was 25 weeks ago even though there have been several mercurial releases since. I think we should really build it from source.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've open #195 to tackle with this someday. Meanwhile, we have the latest hg for the current period because 18.04 was just released weeks ago :)


# Add source for the latest Neovim packages.
RUN add-apt-repository ppa:neovim-ppa/stable

# Install basic development packages.
RUN __LLVM_VERSION__="6.0" \
&& apt-get update \
&& apt-get install -y --no-install-recommends \
&& DEBIAN_FRONTEND=noninteractive apt-get install -y --no-install-recommends \
autoconf \
automake \
bash-completion \
Expand Down