Skip to content

Conversation

nt1m
Copy link
Member

@nt1m nt1m commented Mar 16, 2018

No description provided.

Copy link
Member

@jankeromnes jankeromnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution! 👍

Quick question: What is this supposed to achieve? I don't think this would transpire into user's Bash environments (need to edit ~/.bashrc for that). Are you fixing some graphical RUN command in another Dockerfile?

Also, please note that we already attempt to set DISPLAY=:98 via /etc/environment 4 lines above, but it doesn't seem to work for Bash sessions on Janitor. Maybe we need to stop using /etc/environment and move everything into the user's ~/.bashrc?

Follow-up thought: We're heavily customizing ~/.bashrc to make Janitor work on Bash, but this doesn't work for ZSH, Fish, etc. Maybe we should move all Janitor-related ~/.bashrc customization into a dedicated ~/.janitorrc file, and source that file in ~/.bashrc, ~/.zshrc, ~/.fishrc etc?

@nt1m
Copy link
Member Author

nt1m commented Mar 19, 2018

What is this supposed to achieve?

./mach run still doesn't work, and it does heavily annoy me having to go to VNC to run it there :)

@jankeromnes
Copy link
Member

jankeromnes commented Mar 19, 2018

./mach run still doesn't work, and it does heavily annoy me having to go to VNC to run it there :)

Understandable! Sorry about this frustrating caveat.

Please export the DISPLAY variable in a common ~/.janitorrc script, and source this script in ~/.bashrc. (Using ENV in the Dockerfile won't solve the problem I think.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants