Skip to content

Conversation

JackRobards
Copy link
Owner

This PR excludes ES symbol types from unions when checking bindings.
This ensures that nothing and noChange are ignored in type checking.

We remove all symbol types because it is not possible to get the details of symbol types.
This will produce false negatives when other symbols are mixed in, but I consider such situations to be rare.

Closes runem#207. Closes runem#251. Closes runem#316.

This PR does not resolve the issue of ifDefined not supporting null (even though Lit v3 does).
It will probably be resolved when we stop treating ifDefined specially, or when runem#296 is merged.
The user can use either a custom directive or value ?? nothing instead of ifDefined to workaround the issue.

Not a change I made, it is taken from this PR:
runem#364

Thank you to the original author!

I did not include the "node_modules/typescript/lib/lib.es2015.d.ts" addition from the original PR, since I believe it is not needed with the TS updates in this repo 🤞.

Taken from this PR/commit from the original repo.
runem#364
Copy link

changeset-bot bot commented Jan 20, 2025

⚠️ No Changeset found

Latest commit: f8d79fb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@JackRobards JackRobards merged commit 8e3ff69 into main Jan 20, 2025
6 checks passed
@JackRobards JackRobards deleted the exclude-symbols-from-binding-types branch January 20, 2025 04:35
@JackRobards JackRobards mentioned this pull request Jan 17, 2025
7 tasks
@github-actions github-actions bot mentioned this pull request Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant