Skip to content

Conversation

joshdentremont
Copy link
Contributor

Purpose / why

Adding information about customizing your site template sites

What changes were made?

Added a new page with some empty sections that need to be filled in. Some of these are issues that were identified here: #2286

Verification

These sections should be filled in then tested

Interested Parties

  • @Islandora/documentation
  • @Islandora/committers

Checklist

Pull-request Reviewer

Pull-request reviewer should ensure the following:

Person Merging

The person merging should ensure the following:

  • Does mkdocs still build successfully? (This is indicated by TravisCI passing. To test locally, and see warnings, see How To Build Documentation.)
  • If pages are renamed or removed, have all internal links to those pages been fixed?
  • If pages are added, have they been linked to or placed in the menu?
  • Did the PR receive at least one approval from a committer, and all issues raised have been addressed?

@joshdentremont joshdentremont changed the title St customizations Site Template Customizations Documentation May 31, 2024
@aOelschlager aOelschlager self-requested a review June 5, 2024 17:22
@joshdentremont joshdentremont marked this pull request as ready for review July 24, 2025 12:11

### Blocking by User Agent

You can modify how nginx handles certain user agents by modifying `/etc/nginx/shared/drupal.defaults.conf` inside your Drupal container. For example, by adding:
Copy link
Member

@joecorall joecorall Jul 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should add some guidance here on how to do this.

We should utilize buildkit's nginx conf that includes rules from any *.conf file in /etc/nginx/http.d/ in the drupal container. So IMO the guidance should be to bind mount a new file in that location and/or add that to your Dockerfile build. My preference would be to bind mount it in docker compose but building it in the Dockerfile is probably more durable

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In fact, I think this is such a vital part of having a web property available on the internet we should probably just put this rule into the dockerfile in site template with a conf file in that directory so people can edit it

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually making the regex an env var in isle-buildkit might be the best option

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants