feat(ws): allows to choose which messages are handled #149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix Isaksson#150 avoiding reconnection if disconnection was caused by Node-RED - Do not send previous message in error - Adding a graceful stop with code 1001 - handleDataCallback function modified to provide more typed information - Removing event listeners to free memory
|
As explained in the commit message, during my tests I noticed a problem with duplicate messages, which led me to refactor some code. Don't hesitate to let me know if something isn't right for you. Here is a draft package if you want to test it (rename it by removing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, it is me again 😉
Here a proposal for allowing user to choose which message received from the websocket will be handled: