[Feature] Bulk reading in smaller chunks with inter-dealy #407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce a `_throttle` field using `SemaphoreSlim` to manage concurrent requests based on `ConcurrentRequestMaxCount`. Add `AntiThrottling` and `ReleaseConcurrent` methods to handle semaphore operations without parameters, simplifying the code. These changes improve the efficiency and reliability of handling multiple requests.
- Updated `TestConnector.cs` to use hardcoded values for credentials and modified `CertificatePath`. - Added new configuration sections for `HardwareIDs` and `IoAddresses` in `plc_line_HwIdentifiers.st` and `plc_line_IoAddresses.st`. - Significant updates to `apax-lock.json` and `apax.yml` to reflect new dependencies and versions. - Added new certificate files for secure communication. - Created `plc_line.HardwareIdentifiers.json` and `plc_line.IoAddresses.json` for structured data storage. - Updated multiple YAML files for Siemens PLCs with new templates, service parameters, and user management roles. - Modified security configuration with updates to `server.csr` and `server_cert_ext.cnf`.
This commit introduces an `eAccessPriority` parameter to the asynchronous methods in the `WebApiConnector`, `Connector`, and `DummyConnector` classes, allowing for prioritized access when reading and writing batches of `ITwinPrimitive` items. A new enumeration for access priorities has been added in `AccessPriority.cs`, defining levels: `Normal`, `Low`, and `Prioritare`. Method signatures for `ReadBatchAsync` and `WriteBatchAsync` have been updated accordingly, and the implementations of cyclic methods have been modified to support the new parameter. Additionally, test files have been updated to reflect these changes, and unused `using` directives have been removed from `WebApiConnector.cs` for cleaner code.
Refactor bulk read and write test methods to use custom access priority. Renamed methods to reflect the change: - `should_bulk_read_low_priority_with_alternating_parameters` to `should_bulk_read_custom_priority_with_alternating_parameters` - `should_bulk_write_low_priority_with_alternating_parameters` to `should_bulk_write_custom_priority_with_alternating_parameters`. Updated `ReadBatchAsync` and `WriteBatchAsync` calls to use `eAccessPriority.Custom` instead of `eAccessPriority.Low`.
PTKu
deleted the
406-feature-bulk-reading-in-smaller-chunks-with-inter-dealy
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant enhancements to the WebAPI connector, focusing on batch operations, improved prioritization, and better handling of communication with Siemens S7 PLCs. It also includes code cleanup and documentation updates for better maintainability and usability.
Enhancements to Batch Operations:
eAccessPriority) and chunk settings. This allows for optimized data exchange with PLCs. (docfx/articles/connectors/WebAPI.md,src/AXSharp.connectors/src/AXSharp.Connector.S71500.WebAPI/WebApiConnector.cs) [1] [2] [3] [4] [5] [6]Code Cleanup:
WebApiConnector.cs. (src/AXSharp.connectors/src/AXSharp.Connector.S71500.WebAPI/WebApiConnector.cs) [1] [2]Improved Documentation:
WebApiConnectorto provide clearer descriptions and default values for parameters. (src/AXSharp.connectors/src/AXSharp.Connector.S71500.WebAPI/WebApiConnector.cs) [1] [2] [3] [4] [5] [6] [7] [8]Throttling and Concurrency Management:
SemaphoreSlimfor managing concurrent requests, replacing the obsolete anti-throttling methods. (src/AXSharp.connectors/src/AXSharp.Connector.S71500.WebAPI/WebApiConnector.cs) [1] [2] [3] [4]Error Handling:
src/AXSharp.connectors/src/AXSharp.Connector.S71500.WebAPI/WebApiConnector.cs)closes #406