Skip to content

Add peer target parameters for Genesis sync peer selection targets #6231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 10, 2025

Conversation

crocodile-dentist
Copy link
Contributor

@crocodile-dentist crocodile-dentist commented May 27, 2025

Description

This change allows the configuration of the following peer selection target values while syncing in Genesis mode:

  • SyncTargetNumberOfRootPeers
  • SyncTargetNumberOfKnownPeers
  • SyncTargetNumberOfEstablishedPeers

Also, enhanced tracing of big ledger peer snapshot file.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-9.6 and ghc-9.12
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.

@crocodile-dentist crocodile-dentist self-assigned this May 27, 2025
@crocodile-dentist crocodile-dentist requested a review from a team as a code owner May 27, 2025 09:20
@crocodile-dentist crocodile-dentist added the networking Issues and PRs related to networking label May 27, 2025
@Jimbo4350 Jimbo4350 added 10.5 and removed 10.5 labels May 27, 2025
@crocodile-dentist crocodile-dentist force-pushed the mwojtowicz/flexible-sync-targets branch from 96a6285 to fd324b3 Compare May 28, 2025 13:22
@crocodile-dentist crocodile-dentist requested review from a team as code owners May 28, 2025 18:25
@crocodile-dentist crocodile-dentist force-pushed the mwojtowicz/flexible-sync-targets branch 9 times, most recently from 19023f6 to c770ba4 Compare June 3, 2025 14:56
@coot coot requested a review from a team as a code owner June 4, 2025 09:42
@coot coot force-pushed the mwojtowicz/flexible-sync-targets branch from 2ae11f1 to 941e07d Compare June 6, 2025 06:23
@coot coot enabled auto-merge June 6, 2025 06:23
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coot coot added this pull request to the merge queue Jun 10, 2025
Merged via the queue into master with commit 1ff28bc Jun 10, 2025
22 of 23 checks passed
@coot coot deleted the mwojtowicz/flexible-sync-targets branch June 10, 2025 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
networking Issues and PRs related to networking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants