Dds dpp decimation #14312
Dds dpp decimation #14312
Conversation
There was a problem hiding this comment.
Pull Request Overview
This pull request implements DDS embedded filter support for decimation and temporal filters in the DDS system, allowing remote configuration of these filters through the DDS communication layer.
Key changes include:
- Added embedded filter infrastructure with base classes and specialized implementations for decimation and temporal filters
- Implemented DDS communication protocols for filter configuration and querying
- Added C and C++ API extensions for embedded filter sensor interface
Reviewed Changes
Copilot reviewed 39 out of 39 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| third-party/realdds/src/topics/dds-topic-names.cpp | Added topic names for embedded filter controls |
| third-party/realdds/src/dds-embedded-filter.cpp | Implemented core embedded filter classes with JSON serialization |
| third-party/realdds/src/dds-device-impl.cpp | Added filter control message handlers and embedded filter support |
| src/rs.cpp | Added C API functions for embedded filter operations |
| include/librealsense2/hpp/rs_sensor.hpp | Added C++ embedded filter sensor wrapper class |
| examples/decimation-dpp/rs-embedded-decimation.cpp | Added example demonstrating decimation filter usage |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
remibettan
force-pushed
the
dds_dpp_decimation
branch
from
4d266b8 to
78de2fb
Compare
remibettan
force-pushed
the
dds_dpp_decimation
branch
from
3443a4f to
1153696
Compare
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 50 out of 50 changed files in this pull request and generated 6 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
src/media/playback/playback_sensor.h
Outdated
| } | ||
| return processing_blocks_api->get_recommended_processing_blocks(); | ||
| } | ||
| embedded_filters get_embedded_filters() const override { return embedded_filters(); }; |
There was a problem hiding this comment.
Currently options value change is not recordded for DDS devices, see LRS-990
remibettan
force-pushed
the
dds_dpp_decimation
branch
from
444408a to
3332425
Compare
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 49 out of 49 changed files in this pull request and generated 14 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 49 out of 49 changed files in this pull request and generated 8 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
include/librealsense2/h/rs_types.h
Outdated
| RS2_EXTENSION_DEPTH_MAPPING_SENSOR, | ||
| RS2_EXTENSION_LABELED_POINTS, | ||
| RS2_EXTENSION_ETH_CONFIG, | ||
| RS2_EXTENSION_QUERY_EMBEDDED_FILTERS, |
There was a problem hiding this comment.
Please remove QUERY as discussed
| namespace librealsense { | ||
|
|
||
|
|
||
| class query_embedded_filters_interface |
There was a problem hiding this comment.
Consider embedded_filters_list_interface or similar adjective
| query_embedded_filter_callback query_embedded_filter_cb) | ||
| : rs_dds_embedded_filter(dds_embedded_filter, set_embedded_filter_cb, query_embedded_filter_cb) | ||
| , _enabled(false) | ||
| , _alpha(ALPHA_DEFAULT) |
There was a problem hiding this comment.
What are we doing with this members
There was a problem hiding this comment.
leftovers - members removed
| const std::string DELTA_OPTION_NAME = "Delta"; | ||
| const std::string PERSISTENCY_OPTION_NAME = "Persistency"; | ||
|
|
||
| static const float ALPHA_DEFAULT; |
remibettan
merged commit ba2914c
into
IntelRealSense:development
3 participants
Tracked by: RSDEV-3702