Skip to content

Conversation

@rhabacker
Copy link

The changes from this pull request have been adopted by https://build.opensuse.org/package/show/home:rhabacker:branches:games/librealsense and add support for creating libraries in shared mode, which is required by Linux distributions such as openSUSE.

I did run pr_check.sh and api_check.sh under scripts.

@sysrsbuild
Copy link
Collaborator

Can one of the admins verify this patch?

@rhabacker rhabacker force-pushed the fixes branch 3 times, most recently from 3e2a2e5 to 2bf8c9d Compare July 9, 2025 14:37
@dg0yt
Copy link

dg0yt commented Jul 15, 2025

  • The main library already follows BUILD_SHARED_LIBS.
  • I see no effort to handle the necessary export for MSVC.

@rhabacker rhabacker force-pushed the fixes branch 2 times, most recently from 1a6d704 to c2d0911 Compare July 15, 2025 19:57
@rhabacker
Copy link
Author

  • The main library already follows BUILD_SHARED_LIBS.

There was a spelling error in the commit message, thanks for pointing out.

* I see no effort to handle the necessary  export for MSVC.

The shared build support has been limited to unix like platforms.

@rhabacker
Copy link
Author

Support is currently limited to unix-like platforms and is required by packages on build.opensuse.org.

For the creation of packages with shared libraries on Linux distributions such as openSUSE, it should also be noted that third-party packages such as curl and nlohmann_json are included in separate packages, see for example https://build.opensuse.org/projects/hardware/packages/librealsense/files/0001-third-party-use-nlohmann_json-from-system.patch?expand=1

@rhabacker rhabacker changed the title Add support to build libraries in shared mode Improved support to build libraries in shared mode Jul 21, 2025
@dg0yt
Copy link

dg0yt commented Jul 22, 2025

Maybe it would be better to not put more topics in a single PR.

@rhabacker
Copy link
Author

Maybe it would be better to not put more topics in a single PR.

See #14155

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants