-
Notifications
You must be signed in to change notification settings - Fork 4.9k
Improved support to build libraries in shared mode #14125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: development
Are you sure you want to change the base?
Conversation
|
Can one of the admins verify this patch? |
3e2a2e5 to
2bf8c9d
Compare
|
1a6d704 to
c2d0911
Compare
There was a spelling error in the commit message, thanks for pointing out.
The shared build support has been limited to unix like platforms. |
For the creation of packages with shared libraries on Linux distributions such as openSUSE, it should also be noted that third-party packages such as curl and nlohmann_json are included in separate packages, see for example https://build.opensuse.org/projects/hardware/packages/librealsense/files/0001-third-party-use-nlohmann_json-from-system.patch?expand=1 |
|
Maybe it would be better to not put more topics in a single PR. |
See #14155 |
The changes from this pull request have been adopted by https://build.opensuse.org/package/show/home:rhabacker:branches:games/librealsense and add support for creating libraries in shared mode, which is required by Linux distributions such as openSUSE.
I did run pr_check.sh and api_check.sh under scripts.