Add scope table #65
Draft
Add scope table #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -88,7 +88,7 @@ TEST_IFX(analogio_adc, test_adc_read_default_vdda_vref_pin) | |||
| { | |||
| analogReference(DEFAULT); | |||
| int adc_value = analogRead(TEST_PIN_ANALOG_IO_VREF); | |||
| int expected_value = TEST_ADC_RESOLUTION; | |||
| int expected_value = ADC_RESOLUTION; | |||
There was a problem hiding this comment.
Please do not change the name TEST_ADC_RESOLUTION in the file here because this is needed for PSOC. Instead you could define in the test_config.h file
#define TEST_ADC_RESOLUTION ADC_RESOLUTION
| @@ -226,8 +185,6 @@ TEST_GROUP_RUNNER(pulse_board1) { | |||
|
|
|||
| RUN_TEST_CASE(pulse_board1, test_high_pulse_duration); | |||
| RUN_TEST_CASE(pulse_board1, test_low_pulse_duration); | |||
| RUN_TEST_CASE(pulse_board1, test_high_pulse_long_duration); | |||
| RUN_TEST_CASE(pulse_board1, test_low_pulse_long_duration); | |||
| RUN_TEST_CASE(pulse_board1, test_pulse_timeout); | |||
There was a problem hiding this comment.
Why are these tests removed? In case you want to exclude it for xmc please use compiler switch instead.
| @@ -18,6 +18,8 @@ | |||
| #define TONE_PIN_OUTPUT TEST_PIN_DIGITAL_IO_OUTPUT | |||
| #define TONE_PIN_FEEDBACK TEST_PIN_DIGITAL_IO_INPUT | |||
|
|
|||
| typedef int PinStatus; | |||
LinjingZhang
requested changes
Aug 13, 2025
|
Any reasons for this to be on hold? |
jaenrig-ifx
approved these changes
Aug 25, 2025
jaenrig-ifx
requested changes
Aug 25, 2025
Signed-off-by: Eder Julian <[email protected]>
This reverts commit 5866d18.
This reverts commit 5866d18.
wxyyy0117
force-pushed
the
add-scope-table
branch
from
46f0778 to
a809cff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By creating this pull request you agree to the terms in CONTRIBUTING.md.
https://github.com/Infineon/.github/blob/master/CONTRIBUTING.md
--- DO NOT DELETE ANYTHING ABOVE THIS LINE ---
Added a scope table in readme, showing if the tests are valid for different xmc versions and microcontrollers. Also fixed small bugs to enable tests.