webkit-dev-ci-tools image: ship netdata but with systemd unit disabled #565
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On the WebKit image created via cross-toolchain-helper script we have been including netdata for a while in the local.conf files there because we use this to capture performance data from the RPi4 bots when those are running the tests. However, this netdata service should not be started by default because it is only useful on the bots, but it is not useful for developers and it may cause CPU spikes if not configured properly. When the bots are deployed we setup a specific configuration for netdata (to rely the data to a remote server) and we also take care of enabling the systemd unit there. So this patch adds netdata into the image but configures it to be disabled by default. Meanwhile at it, disable also the apache2 service which is not needed (the service) for the tests (having the binary is enough).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the WebKit image created via cross-toolchain-helper script we have been including netdata for a while in the local.conf files there because we use this to capture performance data from the RPi4 bots when those are running the tests.
However, this netdata service should not be started by default because it is only useful on the bots, but it is not useful for developers and it may cause CPU spikes if not configured properly.
When the bots are deployed we setup a specific configuration for netdata (to rely the data to a remote server) and we also take care of enabling the systemd unit there.
So this patch adds netdata into the image but configures it to be disabled by default. Meanwhile at it, disable also the apache2 service which is not needed (the service) for the tests (having the binary is enough).