make RP aware of running behind ssl terminating front end proxy #118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohe
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The exisiting Flask RP example application was not recoginizing X-Forwarded-* headers properly. For example if you run the example application behind a Treafik Proxy which is terminating TLS, the flask-rp application publishing http:// urls when registering itself at the Flaks-OP Provider instance.
This PR make use of the ProxyFix method to make the flask application acknownledge the forwarded headers properly.
Refer: https://werkzeug.palletsprojects.com/en/stable/middleware/proxy_fix/