-
Notifications
You must be signed in to change notification settings - Fork 9
Restore exports #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore exports #11
Conversation
They were dropped (by mistake, I assume) in fb96177.
|
I suppose another issue is that the tests are structured such that they didn't notice this. |
Codecov Report
@@ Coverage Diff @@
## master #11 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 1 1
Lines 29 29
=====================================
Hits 29 29
Continue to review full report at Codecov.
|
|
Wasn't a mistake, want to discourage |
|
(The tests were changed accordingly) |
|
Hmm, interesting. What is the rationale? (Is this a larger trend or is it currently limited to your packages?) |
|
Rationale is that namespace pollution is bad. |
|
Closing. |
|
Fwiw, I never really agreed with this decision. If the user doesn't want namespace pollution, they are always free to write But #21 provides a sensible way forward, too. |
They were dropped (by mistake, I assume) in fb96177.