Skip to content

[ITensors] Add prime indices for inner in documentation #1124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 22, 2023

Conversation

ryanlevy
Copy link
Contributor

Description

inner(x,A,x) was deprecated but the docs aren't updated to show this. I added this to the docs and inner documentation page. I left out the Apply(A,x) option but can add that in if you want to mention it.

I should also note that inner(A,x,A,x) only works without primes at the moment (#696 )

Checklist:

  • My code follows the style guidelines of this project. Please run using JuliaFormatter; format(".") in the base directory of the repository (~/.julia/dev/ITensors) to format your code according to our style guidelines.
  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.

@mtfishman
Copy link
Member

Thanks! Too bad about the AD test failures, probably there was a regression in Zygote, which has been the case for previous AD test regressions (i.e. GTorlai/PastaQ.jl#300).

@mtfishman mtfishman merged commit 9f96579 into ITensor:main May 22, 2023
@emstoudenmire
Copy link
Collaborator

Thanks Ryan!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants