Skip to content

WIP: Is23/web api list account requests and users for PO center #7560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Apr 22, 2025

What do these changes do?

  • 📝 Doc simcore services OpenAPI Specs and Docker images
  • User fills the form -> inject in users_pre_regististration table new states APPROVAL_PENDING, APPROVAL_DENIED
  • list GET /admin/users. Filter by state and sort by created_at

Related issue/s

How to test

Dev-ops

None

@pcrespov pcrespov self-assigned this Apr 22, 2025
Copy link

codecov bot commented Apr 22, 2025

Codecov Report

Attention: Patch coverage is 39.65517% with 35 lines in your changes missing coverage. Please review.

Project coverage is 71.95%. Comparing base (e6f13b1) to head (998c81c).
Report is 5 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (e6f13b1) and HEAD (998c81c). Click for more details.

HEAD has 6 uploads less than BASE
Flag BASE (e6f13b1) HEAD (998c81c)
unittests 30 26
integrationtests 6 4
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #7560       +/-   ##
===========================================
- Coverage   87.62%   71.95%   -15.68%     
===========================================
  Files        1752     1532      -220     
  Lines       67864    60633     -7231     
  Branches     1121      630      -491     
===========================================
- Hits        59467    43628    -15839     
- Misses       8089    16877     +8788     
+ Partials      308      128      -180     
Flag Coverage Δ
integrationtests 49.00% <27.08%> (-16.12%) ⬇️
unittests 72.42% <39.65%> (-14.39%) ⬇️
Components Coverage Δ
api 76.84% <ø> (ø)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library 92.73% <100.00%> (+<0.01%) ⬆️
pkg_notifications_library 77.23% <ø> (-8.04%) ⬇️
pkg_postgres_database 62.23% <100.00%> (-25.96%) ⬇️
pkg_service_integration 69.98% <ø> (ø)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 65.66% <ø> (-19.74%) ⬇️
agent 96.46% <ø> (ø)
api_server 89.80% <ø> (-1.44%) ⬇️
autoscaling 96.08% <ø> (ø)
catalog 63.56% <ø> (-28.90%) ⬇️
clusters_keeper 99.24% <ø> (ø)
dask_sidecar 91.29% <ø> (ø)
datcore_adapter 98.12% <ø> (ø)
director 76.87% <ø> (+0.09%) ⬆️
director_v2 72.34% <ø> (-18.97%) ⬇️
dynamic_scheduler 97.40% <ø> (ø)
dynamic_sidecar 89.17% <ø> (-0.94%) ⬇️
efs_guardian 83.60% <ø> (-6.20%) ⬇️
invitations 93.28% <ø> (ø)
payments 77.74% <ø> (-14.93%) ⬇️
resource_usage_tracker 62.62% <ø> (-26.61%) ⬇️
storage 50.00% <ø> (-37.70%) ⬇️
webclient ∅ <ø> (∅)
webserver 58.23% <27.08%> (-27.81%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6f13b1...998c81c. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pcrespov pcrespov changed the title WIP: Is23/web api list users for admin WIP: Is23/web api list account requests and users for PO center Apr 23, 2025
@pcrespov pcrespov added this to the Pauwel Kwak milestone Apr 23, 2025
@pcrespov pcrespov added the a:webserver issue related to the webserver service label Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:webserver issue related to the webserver service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant