Skip to content

AWS Deployments: close redis external port #810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

YuryHrytsuk
Copy link
Collaborator

What do these changes do?

Do not expose self-hosted Redis. There is no need since we only need it for AWS Master which now uses AWS-hosted Redis

Related issue/s

Related PR/s

Checklist

  • I tested and it works

Copy link
Member

@mrnicegyu11 mrnicegyu11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the AWS memoryDB already in aws-master active? Nice!

@YuryHrytsuk YuryHrytsuk merged commit dd8ecb8 into ITISFoundation:main Sep 18, 2024
3 checks passed
@YuryHrytsuk
Copy link
Collaborator Author

YuryHrytsuk commented Sep 18, 2024

Is the AWS memoryDB already in aws-master active? Nice!

And used.

We use Redis OSS (not MemoryDB) because it supports multiple databases while MemoryDB does not support multiple Redis Databases.

The reason is MemoryDB is implemented as Redis Cluster and Redis Cluster does not support SELECT statement (required for multiple databases) by definition of it.

it is documented here: https://git.speag.com/oSparc/osparc-ops-deployment-configuration/-/blob/configs/deployments/osparc-master-zmt.click/terraform/ElasticCache.tf?ref_type=heads#L44-46

@YuryHrytsuk YuryHrytsuk deleted the aws-close-external-redis-port branch September 18, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants