Skip to content

Redis commander: fundamental refactoring #803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 17, 2024
Merged

Redis commander: fundamental refactoring #803

merged 5 commits into from
Sep 17, 2024

Conversation

YuryHrytsuk
Copy link
Collaborator

@YuryHrytsuk YuryHrytsuk commented Sep 17, 2024 •
edited
Loading

What do these changes do?

  • Use connections instead of REDIS_HOSTS (it does not support redis_username)
  • Use ghcr.io/joeferner/redis-commander:0.8.1 since current image does not support redis_username
    • The new image is well documented and also has recent releases
  • Remove 'rediscommander` docker node label
  • Remove deployment specific docker compose files and Makefile targets

FYI: @GitHK

Related issue/s

Related PR/s

Checklist

  • I tested and it works

@YuryHrytsuk YuryHrytsuk added t:enhancement New feature or request p:mid-prio labels Sep 17, 2024
@YuryHrytsuk YuryHrytsuk added this to the Doppelbock milestone Sep 17, 2024
@YuryHrytsuk YuryHrytsuk self-assigned this Sep 17, 2024
@YuryHrytsuk YuryHrytsuk mentioned this pull request Sep 17, 2024
Closed
mrnicegyu11
mrnicegyu11 approved these changes Sep 17, 2024
View reviewed changes
Copy link
Member

@mrnicegyu11 mrnicegyu11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very good and elegant I found no flaws. Thanks!

@YuryHrytsuk YuryHrytsuk merged commit e673841 into ITISFoundation:main Sep 17, 2024
3 checks passed
@YuryHrytsuk YuryHrytsuk changed the title Redis commander: use connections file Redis commander: fundamental refactoring Sep 17, 2024
This was referenced Sep 17, 2024
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrnicegyu11 mrnicegyu11 mrnicegyu11 approved these changes

Assignees

@YuryHrytsuk YuryHrytsuk

Labels
p:mid-prio t:enhancement New feature or request
Projects
None yet
Milestone
MartinKippenberger
Development

Successfully merging this pull request may close these issues.
2 participants
@YuryHrytsuk @mrnicegyu11