change index.html #9
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isshun226
reviewed
Nov 9, 2019
Comment on lines
+11
to
+37
| <div id="todo"> | ||
| <div id="going">進行中のタスク</div> | ||
| <div id="break" >中断されているタスク</div> | ||
| <div id="limit">期限切れのタスク</div> | ||
| <div id="end">完了済みのタスク</div> | ||
| </div> | ||
|
|
||
| <div id="search"> | ||
| <div>検索</div> | ||
| <div>ワード検索</div> | ||
| <input type="text" id="keyword"> | ||
| <input type="button" id="keyword_search" value="ワード検索" onclick="serchWord()"> | ||
| <div>タグ検索</div> | ||
| <input type="text" id="tag"> | ||
| <input type="button" id="tag_search" value="タグ検索" onclick="serchTag()"> | ||
| </div> | ||
|
|
||
| <div id="new"> | ||
| <div>新規作成</div> | ||
| <div>内容</div> | ||
| <input type="text" id="value_input"> | ||
| <div>期限</div> | ||
| <input type="text" id="limit_input"> | ||
| <div>タグ</div> | ||
| <input type="text" id="tag_input"> | ||
| <input type="button" id="create" value="新規作成" onclick="createNewTask()"> | ||
| </div> |
Collaborator
There was a problem hiding this comment.
divは意味のないタグなのでコンテンツに取って意味のある機能、パーツである場合はsectionタグを使いましょう。
あまり細かいところまで気にする必要はないですが、意識した方が見栄えは綺麗になります
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.