ADD style.css #12
Open
ADD style.css #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isshun226
reviewed
Nov 10, 2019
Collaborator
isshun226
left a comment
isshun226
left a comment
There was a problem hiding this comment.
全体的にcssのセレクタ名がわかりづらいのでもう少しわかりやすい名前をしましょう。
それと共通のCSS等は何度も書き直すよりClassに抽出して共有した方が良さそうです。
そういう意味でClassとIDの使い分けを見直しましょう。
後、できればfloatは使わないのが望ましいです。flex便利だよ！
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.