Fix support for y4m color spaces #629
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for the following Y4M color spaces produced by ffmpeg: * 422 * 420 * 420jpeg * 420mpeg2 * 420paldv * 422 * 444 * mono * 411 * 420p10 * 422p10 * 444p10 * mono10 * 420p12 * 422p12 * 444p12 * mono12 * 420p14 * 422p14 * 444p14 * 420p16 * 422p16 * 444p16 * mono16 Unsupported spaces: * 444alpha * 420p9 * 422p9 * 444p9 * mono9 Tested: * opened a 400 image.
This fixes the Y4M parser, though yuview eventually refused to read the file. Error before: "Error parsing the Y4M header: Could not locate the next 'FRAME' indicator". Note that the parser cannot deal correctly with the odd-dimensions. Error after: "With the given settings, the YUV data can not be converted to RGB: The item width 9 must be divisible by the horizontal subsampling factor 2. The item height 9 must be divisible by the horizontal subsampling factor 2." Now the problem is that yuview does not seem to support odd dimensions for subsampled files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for the following Y4M color spaces produced by ffmpeg:
Unsupported spaces:
Tested: