Skip to content

Rework the Statistics Item #612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 53 commits into
base: develop
Choose a base branch
from
Draft

Rework the Statistics Item #612

wants to merge 53 commits into from

Conversation

ChristianFeldmann
Copy link
Member

@ChristianFeldmann ChristianFeldmann commented Jan 16, 2025 •
edited
Loading

Rework the Statistics Item

Things to do:

  • Test statistics loading / saving in App
  • Add test for real loading of statistics file

ChristianFeldmann and others added 30 commits January 10, 2025 21:51
@ChristianFeldmann
Modify classes that use the new statistics type
437da37
@ChristianFeldmann
Don't check rendering of grid. What does this have to do with anything?
4ed687c
@ChristianFeldmann
Use StatsTypeBuilder instead of intransparent constructors
bf3c146
@ChristianFeldmann
Compile fix for ubuntu
9976e7a
@ChristianFeldmann
Merge branch 'feature/reworkStatisticsType' of github.com:IENT/YUView…
eb59d59 
… into feature/reworkStatisticsType
@ChristianFeldmann
Fix compilation GCC
f1a4c26
@ChristianFeldmann
Fix tests
2defa85
@ChristianFeldmann
Try c++ 20
cf7650b
@ChristianFeldmann
Merge branch 'feature/reworkStatisticsType' of github.com:IENT/YUView…
c2b3392 
… into feature/reworkStatisticsType
@ChristianFeldmann
Add support for c++ 20 also with gcc 9
e76e96d
@ChristianFeldmann
Add missing widget lib
da5bb18
@ChristianFeldmann
Merge branch 'feature/reworkStatisticsType' of github.com:IENT/YUView…
ef5f4a4 
… into feature/reworkStatisticsType
@ChristianFeldmann
Typo in widgets
a75c0c9
@ChristianFeldmann
Add test fur StatisticsTypeBuilder
1de46fb
@ChristianFeldmann
Constructor
96cfeef
@ChristianFeldmann
Construction of struct 2
c377ba6
@ChristianFeldmann
Add saving/loading back
dc4599c
@ChristianFeldmann
Merge branch 'feature/reworkStatisticsType' of github.com:IENT/YUView…
abcff36 
… into feature/reworkStatisticsType
@ChristianFeldmann
Add missing operators. Emplace on optional does not want to work in GCC.
7d937fa
@ChristianFeldmann
Make types only creatable through builder.
ab862ea
@ChristianFeldmann
Name optional function separately. This is problematic on older clang.
5b2136a
@ChristianFeldmann
Move storage and loading of statis items to separate class for testing.
e70a09b
@ChristianFeldmann
Add modofied type container
e707f4f
@ChristianFeldmann
Add scale by percent function
d3d5e60
@ChristianFeldmann
Add explicit conversion
8bcdf28
@ChristianFeldmann
Make render and alpha values use the modified struct
4ca565e
@ChristianFeldmann
Missing header for GCC
f9abca4
@ChristianFeldmann
Store initial value so that return to initial value is also detected …
2bf16ea 
…as not modified.
@ChristianFeldmann
Add arrow operator
14fccec
@ChristianFeldmann
Add modified to the value data
f3d9cf9
ChristianFeldmann and others added 23 commits January 29, 2025 17:06
@ChristianFeldmann
Missing optional check
9a45e53
@ChristianFeldmann
Reformat wasModified function for valueDataOptions
f22aa24
@ChristianFeldmann
Make vectorDataOptions use modified tool
9315f47
@ChristianFeldmann
Move grid options to modified handler
ec89168
@ChristianFeldmann
Add tests for comparison operators
12d617e
@ChristianFeldmann
Add test for grid options
f24da72
@ChristianFeldmann
Remove set function. That is the task of the builder.
d815715
@ChristianFeldmann
Clean up comparison functions
40c9174
@ChristianFeldmann
Fix C++ 20 lambda warnings
2b05f96
@ChristianFeldmann
Test default construction values.
e75c9ae
@ChristianFeldmann
Add more tests and default
89e9cd0
@ChristianFeldmann
Add saveing tests
8afc1da
@ChristianFeldmann
Compile fix GCC
f6de2ea
@ChristianFeldmann
Fix GCC warnings
b9ada44
@ChristianFeldmann
Add comparator
9d46bd6
@ChristianFeldmann
Bugfix for loading grid style
84d0543
@ChristianFeldmann
Modify tests to not write to string. That is unstable if the XML libr…
665c6ba 
…ary saves the parameters a bit different. Add remaining loading tests.
@ChristianFeldmann
Make typeID, name and description private so they can not be changed …
baa834d 
…after creation of the StatisticsType
@ChristianFeldmann
Rework the statistics file base a bit. This will need another full re…
6ec024e 
…wite ... but later.
@ChristianFeldmann
Fx some warning and long string compilation
f000581
@ChristianFeldmann
Some more work on the CSV tests
e1cdd5a
Add some pretty printers for Googletest. This really helps to find th…
9e9508f 
…e errors if a check fails.
Refactoring of csv parser and test data
470e701
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ChristianFeldmann