-
Couldn't load subscription status.
- Fork 39
Upgrade kitura #91
base: master
Are you sure you want to change the base?
Upgrade kitura #91
Conversation
sanjeevghimire
commented
May 13, 2019
- upgrade kitura
- new CFC checklist items and model
|
Daaaaaaaang this pull request is large |
|
+27,444 −318 NBD |
|
I think its because of the upgrade and changes are there on both iOS and Server. |
|
I promise to check this by the end of the week. On a side thread, I absolutely will help you get this submitted to the app store tomorrow, but let's take a second look at this and see what we can cull off. |
|
Both app and server are thoroughly tested. There are few things I have
removed which I have enhanced a bit. We can go over that tomorrow, test it
out one more time and push.
On Mon, May 13, 2019 at 7:13 PM David Okun ***@***.***> wrote:
I promise to check this by the end of the week. On a side thread, I
absolutely will help you get this submitted to the app store tomorrow, but
let's take a second look at this and see what we can cull off.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#91?email_source=notifications&email_token=AAM5RWZFN2JEQCQ572U7PDTPVH7Y5A5CNFSM4HMTFUA2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVJ4YTY#issuecomment-492031055>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAM5RWZ5Z7NKONZN7BBOBB3PVH7Y5ANCNFSM4HMTFUAQ>
.
--
सन्जीब िघमिरे
(Sanjeev Ghimire)
|
…n't handle A12 chip effectively.
|
nice |
…ed push notifications creds, fixed bug when starting new game
|
JFYI we have released v1.2 of this app to the app store 🎉 Neil found a bug that I've already fixed with a commit here, and I'm testing to see if there's anything else I can find wrong with it. The bug is not a showstopper, so this version being live is ok, but I intend to review this PR entirely today, and that way 1.2.1 can be released from the master branch. |