Fixes for PQC test cases and Fix Serialization issues with keys. #849
+475
−60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnpeck-us-ibm
requested review from
JinhangZhang,
KostasTsiounis,
jasonkatonica and
taoliult
Needed to remove the dependency of JDK17 in the testcases. Also, there is an issue with serialization. When KeyRep is used to serialize the key the provider order is used to de serialize the key which can cause the wrong key to be created. So, added a new KeyRep class that contains the provider which will allow the correct key to be created. Signed-off-by: John Peck <[email protected]>
johnpeck-us-ibm
force-pushed
the
Issue699-java17
branch
from
3f1034d to
1a4c213
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed to remove the dependency of JDK17 in the testcases. Also, there is an issue with serialization. When KeyRep is used to serialize the key the provider order is used to de serialize the key which can cause the wrong key to be created. So, added a new KeyRep class that contains the provider which will allow the correct key to be created.
back-port: Back-ported from: #680
Signed-off-by: John Peck <[email protected]>