Skip to content

rustup: add pointers to $PATH config in caveats #219866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

rami3l
Copy link
Contributor

@rami3l rami3l commented Apr 13, 2025

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

As suggested by @MikeMcQuaid, this is PR updates the caveats section of the rustup formula to prepare for #218316.

@github-actions github-actions bot added the rust Rust use is a significant feature of the PR or issue label Apr 13, 2025
@rami3l
Copy link
Contributor Author

rami3l commented Apr 13, 2025

(This looks like a connection error: a caveats change shouldn't influence the CI status.)

@rami3l rami3l mentioned this pull request Apr 13, 2025
6 tasks
@daeho-ro daeho-ro added the CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. label Apr 13, 2025
@MikeMcQuaid
Copy link
Member

Passing on this one @rami3l as it's not Homebrew-specific (which our caveats always should be) and we already cover this in our rust formula. Thanks anyway for the PR (and for the others!).

@rami3l
Copy link
Contributor Author

rami3l commented Apr 14, 2025

Passing on this one @rami3l as it's not Homebrew-specific (which our caveats always should be) and we already cover this in our rust formula. Thanks anyway for the PR (and for the others!).

@MikeMcQuaid I'm sorry, but I believe your suggestion for rust caveats was to consult brew info rustup so this PR should be merged before that one... I think there might be a misunderstanding going on here.

@MikeMcQuaid MikeMcQuaid reopened this Apr 14, 2025
@MikeMcQuaid
Copy link
Member

@rami3l Apologies. Can this be reworded to be a bit more specific to Homebrew's rust instead?

@rami3l rami3l closed this Apr 14, 2025
@rami3l rami3l requested review from a team and MikeMcQuaid as code owners April 14, 2025 14:50
@github-actions github-actions bot added automerge-skip `brew pr-automerge` will skip this pull request workflows PR modifies GitHub Actions workflow files autobump alias and removed rust Rust use is a significant feature of the PR or issue labels Apr 14, 2025
@rami3l
Copy link
Contributor Author

rami3l commented Apr 14, 2025

@MikeMcQuaid I'm sorry, but due to a problematic Git operation from my side I cannot open this PR again. Would you mind having a look at #220021?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alias autobump automerge-skip `brew pr-automerge` will skip this pull request CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. workflows PR modifies GitHub Actions workflow files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants