Skip to content

Onnxruntime fix #215960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
98 changes: 98 additions & 0 deletions Formula/o/onnxnostaticreg.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,98 @@
class Onnxnostaticreg < Formula
desc "Open standard for machine learning interoperability (built for onnxruntime)"
homepage "https://onnx.ai/"
url "https://github.com/onnx/onnx/archive/refs/tags/v1.17.0.tar.gz"
sha256 "8d5e983c36037003615e5a02d36b18fc286541bf52de1a78f6cf9f32005a820e"
license "Apache-2.0"

depends_on "cmake" => [:build, :test]
depends_on "abseil"
depends_on "protobuf"

uses_from_macos "python" => :build

def install
args = %W[
-DBUILD_SHARED_LIBS=ON
-DCMAKE_INSTALL_RPATH=#{rpath}
-DONNX_DISABLE_STATIC_REGISTRATION=ON
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we just rebuild onnx with this configuration instead?

Copy link
Author

@chetant chetant Mar 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can, and it will build, but any program linking with onnx only (and using nodes) will not work correctly, since it will skip over the schema registration at startup.

-DONNX_USE_PROTOBUF_SHARED_LIBS=ON
-DPYTHON_EXECUTABLE=#{which("python3")}
]

system "cmake", "-S", ".", "-B", "build", *args, *std_cmake_args
system "cmake", "--build", "build"
system "cmake", "--install", "build"
end

test do
# https://github.com/onnx/onnx/blob/main/onnx/test/cpp/ir_test.cc
(testpath/"test.cpp").write <<~CPP
#include <cassert>
#include <cctype>
#include <memory>
#include <string>
#include <onnx/common/ir.h>
#include <onnx/common/ir_pb_converter.h>
using namespace onnx;

bool IsValidIdentifier(const std::string& name) {
if (name.empty()) {
return false;
}
if (!isalpha(name[0]) && name[0] != '_') {
return false;
}
for (size_t i = 1; i < name.size(); ++i) {
if (!isalnum(name[i]) && name[i] != '_') {
return false;
}
}
return true;
}

int main() {
Graph* g = new Graph();
g->setName("test");
Value* x = g->addInput();
x->setUniqueName("x");
x->setElemType(TensorProto_DataType_FLOAT);
x->setSizes({Dimension("M"), Dimension("N")});
Node* node1 = g->create(kNeg, 1);
node1->addInput(x);
g->appendNode(node1);
Value* temp1 = node1->outputs()[0];
Node* node2 = g->create(kNeg, 1);
node2->addInput(temp1);
g->appendNode(node2);
Value* y = node2->outputs()[0];
g->registerOutput(y);

ModelProto model;
ExportModelProto(&model, std::shared_ptr<Graph>(g));

for (auto& node : model.graph().node()) {
for (auto& name : node.output()) {
assert(IsValidIdentifier(name));
}
}
return 0;
}
CPP

(testpath/"CMakeLists.txt").write <<~CMAKE
cmake_minimum_required(VERSION 3.10)
project(test LANGUAGES CXX)
find_package(ONNX CONFIG REQUIRED)
add_executable(test test.cpp)
target_link_libraries(test ONNX::onnx)
CMAKE

ENV.delete "CPATH"
args = ["-DCMAKE_FIND_PACKAGE_PREFER_CONFIG=ON"]
args << "-DCMAKE_BUILD_RPATH=#{lib};#{HOMEBREW_PREFIX}/lib" if OS.linux?
system "cmake", "-S", ".", "-B", "build", *args
system "cmake", "--build", "build"
system "./build/test"
end
end
2 changes: 1 addition & 1 deletion Formula/o/onnxruntime.rb
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ class Onnxruntime < Formula
depends_on "safeint" => :build
depends_on "abseil"
depends_on "nsync"
depends_on "onnx"
depends_on "onnxnostaticreg"
depends_on "protobuf"
depends_on "re2"

Expand Down
Loading