-
-
Notifications
You must be signed in to change notification settings - Fork 12.7k
Onnxruntime fix #215960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
chetant
wants to merge
2
commits into
Homebrew:master
Choose a base branch
from
chetant:onnxruntime_fix
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Onnxruntime fix #215960
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,98 @@ | ||
class Onnxnostaticreg < Formula | ||
desc "Open standard for machine learning interoperability (built for onnxruntime)" | ||
homepage "https://onnx.ai/" | ||
url "https://github.com/onnx/onnx/archive/refs/tags/v1.17.0.tar.gz" | ||
sha256 "8d5e983c36037003615e5a02d36b18fc286541bf52de1a78f6cf9f32005a820e" | ||
license "Apache-2.0" | ||
|
||
depends_on "cmake" => [:build, :test] | ||
depends_on "abseil" | ||
depends_on "protobuf" | ||
|
||
uses_from_macos "python" => :build | ||
|
||
def install | ||
args = %W[ | ||
-DBUILD_SHARED_LIBS=ON | ||
-DCMAKE_INSTALL_RPATH=#{rpath} | ||
-DONNX_DISABLE_STATIC_REGISTRATION=ON | ||
-DONNX_USE_PROTOBUF_SHARED_LIBS=ON | ||
-DPYTHON_EXECUTABLE=#{which("python3")} | ||
] | ||
|
||
system "cmake", "-S", ".", "-B", "build", *args, *std_cmake_args | ||
system "cmake", "--build", "build" | ||
system "cmake", "--install", "build" | ||
end | ||
|
||
test do | ||
# https://github.com/onnx/onnx/blob/main/onnx/test/cpp/ir_test.cc | ||
(testpath/"test.cpp").write <<~CPP | ||
#include <cassert> | ||
#include <cctype> | ||
#include <memory> | ||
#include <string> | ||
#include <onnx/common/ir.h> | ||
#include <onnx/common/ir_pb_converter.h> | ||
using namespace onnx; | ||
|
||
bool IsValidIdentifier(const std::string& name) { | ||
if (name.empty()) { | ||
return false; | ||
} | ||
if (!isalpha(name[0]) && name[0] != '_') { | ||
return false; | ||
} | ||
for (size_t i = 1; i < name.size(); ++i) { | ||
if (!isalnum(name[i]) && name[i] != '_') { | ||
return false; | ||
} | ||
} | ||
return true; | ||
} | ||
|
||
int main() { | ||
Graph* g = new Graph(); | ||
g->setName("test"); | ||
Value* x = g->addInput(); | ||
x->setUniqueName("x"); | ||
x->setElemType(TensorProto_DataType_FLOAT); | ||
x->setSizes({Dimension("M"), Dimension("N")}); | ||
Node* node1 = g->create(kNeg, 1); | ||
node1->addInput(x); | ||
g->appendNode(node1); | ||
Value* temp1 = node1->outputs()[0]; | ||
Node* node2 = g->create(kNeg, 1); | ||
node2->addInput(temp1); | ||
g->appendNode(node2); | ||
Value* y = node2->outputs()[0]; | ||
g->registerOutput(y); | ||
|
||
ModelProto model; | ||
ExportModelProto(&model, std::shared_ptr<Graph>(g)); | ||
|
||
for (auto& node : model.graph().node()) { | ||
for (auto& name : node.output()) { | ||
assert(IsValidIdentifier(name)); | ||
} | ||
} | ||
return 0; | ||
} | ||
CPP | ||
|
||
(testpath/"CMakeLists.txt").write <<~CMAKE | ||
cmake_minimum_required(VERSION 3.10) | ||
project(test LANGUAGES CXX) | ||
find_package(ONNX CONFIG REQUIRED) | ||
add_executable(test test.cpp) | ||
target_link_libraries(test ONNX::onnx) | ||
CMAKE | ||
|
||
ENV.delete "CPATH" | ||
args = ["-DCMAKE_FIND_PACKAGE_PREFER_CONFIG=ON"] | ||
args << "-DCMAKE_BUILD_RPATH=#{lib};#{HOMEBREW_PREFIX}/lib" if OS.linux? | ||
system "cmake", "-S", ".", "-B", "build", *args | ||
system "cmake", "--build", "build" | ||
system "./build/test" | ||
end | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we just rebuild
onnx
with this configuration instead?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can, and it will build, but any program linking with onnx only (and using nodes) will not work correctly, since it will skip over the schema registration at startup.