Skip to content

fix: add default values into pull_requests page #344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

zluuba
Copy link
Contributor

@zluuba zluuba commented Sep 19, 2023

Добавлены два значения по умолчанию для страницы с pull requests:

  1. Для поля Title/Название дефолтное значение 'Pull request #' + id
  2. Для поля Status/Статус дефолтное значение Open

Насчет дефолтного значения статуса были сомнения, но так как большинство забагованных pull requests были открытыми, оставила этот вариант. Его можно исправить на Closed или Archived/Undefined, но здесь тоже свои плюсы и минусы.

Issue #340

@fey fey merged commit cdd292a into Hexlet:main Sep 19, 2023
@zluuba zluuba deleted the fix-empty-fields-on-pr branch September 19, 2023 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants