improve email uploader error handling #220
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create TaskDetail E-mail
Changing CommunicationJobTypes.TaskDetail from 10 to 12
tweak geoffs email
Layout tweaks
add admin request url to simplified task update email
update nuget references
Next major release
remove repeat message
Merge master into dev
Tweak Edit Requests
mike-f50
approved these changes
Aug 23, 2021
| } | ||
| catch (UnknownTemplateException) | ||
| { | ||
| templateId = CreateNewTemplate(template); |
There was a problem hiding this comment.
Fairly unlikely to happen, but do we have a problem if two hosts run CreateNewTemplate at the same time?
| string plain_content = Regex.Replace(GetEmailHtml(template.name), @"<[^>]*>", String.Empty); | ||
| plain_content = GetEmailText("Layout").Replace("{{Body}}", plain_content); | ||
|
|
||
| success = CreateNewTemplateVersion(new NewTemplateVersion() |
There was a problem hiding this comment.
If templates.templates contains more than one item, success will only show the result from the last item.
| catch (Exception exc) | ||
| { | ||
| foreach (UnsubscribeGroup unsubscribeGroups in templates.deleteUnsubscribeGroups) | ||
| ExpandoObject o = new ExpandoObject(); |
There was a problem hiding this comment.
Happy with this for now, but in due course we probably want to log this to Azure Log Analytics rather than Cosmos.
|
RefreshBehaviour.WaitForFreshData changes look good. |
Add utc conversion
Tweak Task Update email
Use GetLastUpdatedBy
Merge dev into master
Bumps [RestSharp](https://github.com/restsharp/RestSharp) from 106.11.4 to 106.12.0. - [Release notes](https://github.com/restsharp/RestSharp/releases) - [Changelog](https://github.com/restsharp/RestSharp/blob/dev/releasenotes.md) - [Commits](restsharp/RestSharp@106.11.4...106.12) --- updated-dependencies: - dependency-name: RestSharp dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
…ionService/CommunicationService.Core/RestSharp-106.12.0 Bump RestSharp from 106.11.4 to 106.12.0 in /CommunicationService/CommunicationService.Core
jawwadmukhtargmail
force-pushed
the
master
branch
from
d5dcf26 to
386242b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.