[cppia] Fix missing jit exception checks for method calls #1212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In interp mode, we need to stop immediately if a jit exception has been thrown.
tobil4sk
changed the title
This covers the CallHaxe bug
The host must be compiled with HXCPP_CATCH_SEGV so that seg faults are handled as hxcpp exceptions.
tobil4sk
force-pushed
the
fix/missing-jit-exception-checks
branch
from
2643240 to
c75a21a
Compare
|
@hughsando Please check! |
It would be worth double checking if the full
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even with #1188, some checks for jit exceptions in interp code were still missing. This causes control flow bugs when local functions interact with other code, as they are currently not jit compiled.
In short, we have to make sure an exception hasn't been thrown after evaluating the object for a method call.