Skip to content

Marshalling Types #1189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 45 commits into
base: master
Choose a base branch
from
Open

Marshalling Types #1189

wants to merge 45 commits into from

Conversation

Aidan63
Copy link
Contributor

@Aidan63 Aidan63 commented Feb 6, 2025 •
edited
Loading

See HaxeFoundation/haxe#11981 for more details

Aidan63 and others added 30 commits December 15, 2024 12:21
@Aidan63
Add marshal header for value type interop
5dfa55a
@Aidan63
finalise boxed objects if the type has a destructor
ec75e42
@Aidan63
works with static cast
b22a024
@Aidan63
add value type tests
4bc2bcc
@Aidan63
move more conversion functions to reference class
44d5a28
@Aidan63
forward declare everything to avoid order issues
0457958
@Aidan63
ValueType construction from boxed pointer
d718eca
@Aidan63
ValueType no longer inherits from struct
ad7f101
@Aidan63
marshal reference interop with existing pointer types
937868a
@Aidan63
Fix trying to dereference a null pointer when creating a boxed object…
5b00db8 
… from a reference
@Aidan63
add compare traits specialisation for reference null check
73d18dc
@Aidan63
consistent null checking and throwing
d4e7dfe
@Aidan63
raise exceptions when value types are assigned null
46e0cd3
@Aidan63
reference equality operations
e7195b4
@Aidan63
remove no return
f92c9a3
remove some un-needed constructors
b49440f
Make constructors use more templates and use reinterpret cast
7f133d3
use tagged dispatch
d86f57c
support pointer types being held in value type helper
9f8ab77
Add new marshal pointer type
cfb6fee
rename marshal types in prep for more pointer stuff
23da6f1
support reinterpreting value type references
de4c7ec
seemingly working pointer marshalling types
8004100
better null checking with pointer references
5572364
add marshalling tests
2ffcf81
Add pointer collection tests
0978d5b
Move enums into header files
d2a9bcf
test abstract around pointers
50301d3
Pointer type changes
b1231af
add pointer reference to pointer casting
20cb53e
@Aidan63 Aidan63 mentioned this pull request Feb 6, 2025
Open
@skial skial mentioned this pull request Feb 6, 2025
Closed
1 task
@kevinresol
Copy link

Apparently the array access of StdVector extern does not work:

error: type '::cpp::marshal::ValueType< ::std::vector<const ::godot::Variant *>>' does not provide a subscript operator
 1024 | HXLINE( 141)            ptrs[0] = ...;
      |                         ~~~~^~

@Aidan63
Copy link
Contributor Author

Aidan63 commented Apr 5, 2025

Hmm, I'm sure it worked at some point. I'll take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Aidan63 @kevinresol