Add js.lib.NativeStringTools

[terurou]

No description provided.

[RealyUniqueName]

Missing a branch for a case when both locales and options are null.

[terurou]

Thanks for your review! I fixed it.
localeCompare() throws an error when it takes locales = null. So I use undefined.

[RealyUniqueName]

@haxiomic could you please check this?

[haxiomic]

To avoid the need to fill out different cases for argument combinations we can use @:native to the String.prototype methods

For example

@:noClosure
@:native('')
extern class NativeStringTools {

	/**
		Returns a number indicating whether a reference string comes before or after or is
		the same as the given string in sort order.
	 */
	@:native('String.prototype.localeCompare.call')
	public static function localeCompare(string: String, compareString: String, ?locales: EitherType<String, Array<String>>, ?options: CollatorOptions):Bool;
}

using js.lib.NativeStringTools;

trace('a'.localeCompare('b'));

// String.prototype.localeCompare.call("a","b")

I'm not sure if there's a cleaner approach – what do you think @nadako?

[terurou]

ping @nadako @haxiomic
related: #8731 (comment)

[haxiomic]

@terurou I'm looking more at that @:native change, the nulls appearing actually looks to be a bug with calling extern methods within inlined methods

It applies to all externs with @:native or not, the workaround in the short term is to remove inline from abstract BigInt.toLocaleString and others

(nadako is away atm)

[haxiomic]

But if you want to keep the null check approach, then maybe something like

    Syntax.code(
        "({0}).toLocaleString()",
        this,
        locales == null ? js.Lib.undefined : locales,
        options == null ? js.Lib.undefined : options
    );

Is more readable and maintainable

[terurou]

I don't like "prototype call style" because Haxe compiler emits null into optional parameter now. In JavaScript, null and undefined are different type 👎

I think this style is better:

    Syntax.code(
        "({0}).toLocaleString()",
        this,
        locales == null ? js.Lib.undefined : locales,
        options == null ? js.Lib.undefined : options
    );

[Simn]

@kLabz Could you check if we can merge this with #12127?