Assignement in condition warning

[RblSb]

There is also some idea to skip warning when you wrap condition in additional parentheses in first commit.
Related to #8634

var foo = false;
var foo2 = false;
// warning for these cases
var value = (foo = foo2) ? true : false;
if (foo = true) {}
if (foo = null) {}
if ({123; foo = true;}) {}

while (foo = true) {}
do {} while (foo = true);

var dyn:Dynamic = false;
if (dyn = null) {}
if (dyn = false) {}

if ((foo = null) && (foo = true)) {}
if ((foo = null) && ((foo = true) && (foo = true))) {}

// no warning
if ({foo = true; true;}) {}

[kLabz]

That double parenthesis syntax seems out of place :/

[RblSb]

I will write test if you guys think that this is good warning / implementation to have

[kLabz]

For the Dynamic (ie is_bool is false) case, I think it makes sense.

The bool case is more problematic. Assignment of a variable of type T being itself of type T is by design, so writing if (a = true) { ... } is totally valid.

Maybe add a sub warning for the bool case, that would be off by default?