[hl] use classpaths relative_path for get_relative_path #12219
+2
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12215
CPP does not remove it because there is a bug on the relativePath function used by cpp, wheresrc/
is given as a relative path insideclass_paths
, but the pfile is first turn into absolute path before comparisonhaxe/src/generators/cpp/cppContext.ml
Lines 94 to 96 in c11b679
With this change, hl and cpp share the same relative path function, which ignoresrc/
when there is a-cp src
.Don't know where should I change for jvm though.Use the same relative_path function as hxcpp & trace. This still guarantee relative the same std and lib path. This also fix hl's std relative path detection error (caused by an empty classpath before std).