Prefer casting rhs to lhs when unifying equality operators #12190
+6
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was found that when doing
lhs == rhs
, the compiler first tries to assign lhs to rhs and thus also prefers implicit casts in that direction, which seems unintuitive. This change flips the order and so the algorithm is this:I think that's more natural. This is a pretty central change though because it has probably been like that since the original introduction of abstracts. Our unit tests seem fine but there's a failure in the tink tests:
cc @back2dos