Skip to content

Conversation

@ultraviolet10
Copy link
Contributor

@ultraviolet10 ultraviolet10 commented Jun 16, 2025

Linked Issues

Description

cf. issue description

Toggle Checklist

Checklist

Basics

  • B1. I have applied the proper label & proper branch name (e.g. norswap/build-system-caching).
  • B2. This PR is not so big that it should be split & addresses only one concern.
  • B3. The PR targets the lowest branch it can (ideally master).

Reminder: PR review guidelines

Correctness

  • C1. Builds and passes tests.
  • C2. The code is properly parameterized & compatible with different environments (e.g. local,
    testnet, mainnet, standalone wallet, ...).
  • C3. I have manually tested my changes & connected features.

< INDICATE BROWSER, DEMO APP & OTHER ENV DETAILS USED FOR TESTING HERE >

< INDICATE TESTED SCENARIOS (USER INTERFACE INTERACTION, CODE FLOWS) HERE >

  • C4. I have performed a thorough self-review of my code after submitting the PR,
    and have updated the code & comments accordingly.

Architecture & Documentation

  • D1. I made it easy to reason locally about the code, by (1) using proper abstraction boundaries,
    (2) commenting these boundaries correctly, (3) adding inline comments for context when needed.
  • D2. All public-facing APIs are documented in the docs.
    Public APIS and meaningful (non-local) internal APIs are properly documented in code comments.
  • D3. If appropriate, the general architecture of the code is documented in a code comment or
    in a Markdown document.
  • D4. An appropriate Changeset has been generated (and committed) with make changeset for
    breaking and meaningful changes in packages (not required for cleanups & refactors).

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ultraviolet10 ultraviolet10 self-assigned this Jun 16, 2025
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jun 16, 2025

Deploying happychain with  Cloudflare Pages  Cloudflare Pages

Latest commit: 68a48d1
Status:🚫  Build failed.

View logs

@ultraviolet10 ultraviolet10 added reviewing-2 Ready for, or undergoing final review testnet-release labels Jun 16, 2025 — with Graphite App
@linear
Copy link

linear bot commented Jun 16, 2025

HAPPY-624 common <> wallet-common move stuff

- [ ] move getChain from common to wallet-common? + export
- [ ] happy method names should not be in common?
  • HappyMethodNames and TransactionType should be in wallet-common and iframe respectively
  • The LruCache from the submitter can be moved to common/collections
  • I added a copy of waitForCondition (originally in wallet-common) in common — we should use the common version everywhere.
  • shortenAddress from wallet-common can move to common

@ultraviolet10 ultraviolet10 marked this pull request as ready for review June 16, 2025 07:54
Copy link
Contributor

@not-reed not-reed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice one

@ultraviolet10 ultraviolet10 force-pushed the aritra/move-stuff-between-packages branch from 4b99d42 to 68a48d1 Compare June 20, 2025 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

reviewing-2 Ready for, or undergoing final review testnet-release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants