Skip to content

monorepo-wide viem update #524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
May 27, 2025
Merged

monorepo-wide viem update #524

merged 8 commits into from
May 27, 2025

Conversation

ultraviolet10
Copy link
Contributor

@ultraviolet10 ultraviolet10 commented Mar 14, 2025 •
edited
Loading

Linked Issues

This PR updates the viem package to the latest version across apps, demos, and packages.

Description

< DESCRIPTION GOES HERE >

  • Include all relevant context (but no need to repeat the issue's content).
  • Draw attention to new, noteworthy & unintuitive elements.
Toggle Checklist

Checklist

Basics

  • B1. I have applied the proper label & proper branch name (e.g. norswap/build-system-caching).
  • B2. This PR is not so big that it should be split & addresses only one concern.
  • B3. The PR targets the lowest branch it can (ideally master).

Reminder: PR review guidelines

Correctness

  • C1. Builds and passes tests.
  • C2. The code is properly parameterized & compatible with different environments (e.g. local,
    testnet, mainnet, standalone wallet, ...).
  • C3. I have manually tested my changes & connected features.

< INDICATE BROWSER, DEMO APP & OTHER ENV DETAILS USED FOR TESTING HERE >

< INDICATE TESTED SCENARIOS (USER INTERFACE INTERACTION, CODE FLOWS) HERE >

  • C4. I have performed a thorough self-review of my code after submitting the PR,
    and have updated the code & comments accordingly.

Architecture & Documentation

  • D1. I made it easy to reason locally about the code, by (1) using proper abstraction boundaries,
    (2) commenting these boundaries correctly, (3) adding inline comments for context when needed.
  • D2. All public-facing APIs & meaningful (non-local) internal APIs are properly documented in code
    comments.
  • D3. If appropriate, the general architecture of the code is documented in a code comment or
    in a Markdown document.
  • D4. An appropriate Changeset has been generated (and committed) for changes that touch npm published packages (currently pacakges/core and packages/react), see here for more info.

@ultraviolet10 Graphite App
Copy link
Contributor Author

ultraviolet10 commented Mar 14, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Mar 14, 2025
Open
Open
Open
@ultraviolet10 ultraviolet10 changed the title feat: app demo scaffold EIP5792 implementation Mar 14, 2025
@ultraviolet10 ultraviolet10 changed the title EIP5792 implementation EIP5792 implementation base Mar 14, 2025
@ultraviolet10 ultraviolet10 marked this pull request as ready for review March 14, 2025 14:56
@ultraviolet10 ultraviolet10 mentioned this pull request Mar 14, 2025
Closed
11 tasks
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Mar 15, 2025 •
edited
Loading

Deploying happychain with  Cloudflare Pages  Cloudflare Pages

Latest commit: b2b8fba
Status: ✅  Deploy successful!
Preview URL: https://87b85371.happychain.pages.dev
Branch Preview URL: https://aritra-5792-base.happychain.pages.dev

View logs

@ultraviolet10 ultraviolet10 force-pushed the aritra/5792-base branch 2 times, most recently from 937da6c to 439b03a Compare March 24, 2025 12:15
@ultraviolet10 ultraviolet10 added the updating Updating after review label Apr 24, 2025
ultraviolet10
ultraviolet10 commented Apr 28, 2025
View reviewed changes
@ultraviolet10 ultraviolet10 added reviewing-2 Ready for, or undergoing final review reviewing-1 Ready for, or undergoing first-line review and removed updating Updating after review reviewing-2 Ready for, or undergoing final review labels Apr 28, 2025
not-reed
not-reed reviewed May 2, 2025
View reviewed changes
@ultraviolet10 ultraviolet10 force-pushed the aritra/5792-base branch 3 times, most recently from 3aeba53 to eb3e520 Compare May 12, 2025 12:34
@ultraviolet10 ultraviolet10 requested a review from not-reed May 15, 2025 05:34
not-reed
not-reed approved these changes May 21, 2025
View reviewed changes
@ultraviolet10 ultraviolet10 force-pushed the aritra/5792-base branch 2 times, most recently from 99ced7c to a3cbbda Compare May 27, 2025 11:41
@ultraviolet10 ultraviolet10 changed the title EIP5792 implementation base monorepo-wide viem update May 27, 2025
@linear Linear
Copy link

linear bot commented May 27, 2025

HAPPY-582 Upgrade Viem & Wagmi

  • change base wallet_sendCalls PR to be only viem update
  • do another PR on top for wagmi

@ultraviolet10 ultraviolet10 requested review from not-reed and norswap May 27, 2025 11:49
norswap
norswap reviewed May 27, 2025
View reviewed changes
bun.lock Outdated
"viem": ["[email protected].0", "", { "dependencies": { "@noble/curves": "1.8.2", "@noble/hashes": "1.7.2", "@scure/bip32": "1.6.2", "@scure/bip39": "1.5.4", "abitype": "1.0.8", "isows": "1.0.7", "ox": "0.6.9", "ws": "8.18.1" }, "peerDependencies": { "typescript": ">=5.0.4" }, "optionalPeers": ["typescript"] }, "sha512-hvO4l5JIOnYPL8imULoFQiVTSkebIqzGHmIfsdMfIHpAgBaCx8rJJH9cXAxQeWCqsFuTmjEj1cX912N7HSCgpQ=="],
"viem": ["[email protected].1", "", { "dependencies": { "@noble/curves": "1.8.2", "@noble/hashes": "1.7.2", "@scure/bip32": "1.6.2", "@scure/bip39": "1.5.4", "abitype": "1.0.8", "isows": "1.0.7", "ox": "0.6.9", "ws": "8.18.1" }, "peerDependencies": { "typescript": ">=5.0.4" }, "optionalPeers": ["typescript"] }, "sha512-hvO4l5JIOnYPL8imULoFQiVTSkebIqzGHmIfsdMfIHpAgBaCx8rJJH9cXAxQeWCqsFuTmjEj1cX912N7HSCgpQ=="],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect you did a search & replace, which ended up including this file ... as you can see, the hash is the same and this is what causes the integrity check to pass.

Surprisingly still works locally which is probably why you overlooked this. bun install is stable too.

We can't be marking PRs up for review before we have all the tests passing though, let's be pro :')

@linear Linear
Copy link

linear bot commented May 27, 2025

HAPPY-582 Upgrade Viem & Wagmi

  • change base wallet_sendCalls PR to be only viem update
  • do another PR on top for wagmi

@norswap norswap force-pushed the aritra/5792-base branch from af35b31 to b2b8fba Compare May 27, 2025 22:39
@norswap norswap merged commit 2892ddd into master May 27, 2025
6 checks passed
@norswap norswap deleted the aritra/5792-base branch May 27, 2025 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@norswap norswap norswap left review comments

@not-reed not-reed Awaiting requested review from not-reed

Assignees
No one assigned
Labels
reviewing-1 Ready for, or undergoing first-line review testnet-release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ultraviolet10 @norswap @not-reed