Skip to content

Conversation

j-towns
Copy link
Collaborator

@j-towns j-towns commented Jan 3, 2018

No description provided.

@j-towns
Copy link
Collaborator Author

j-towns commented Jan 4, 2018

The test failures appear to have been caused by an issue with Travis/Github.

@mattjj
Copy link
Contributor

mattjj commented Feb 24, 2018

Nice simplification! But should we just remove this function? Your revision makes clear that it's redundant with make_hvp.

@j-towns
Copy link
Collaborator Author

j-towns commented Feb 27, 2018

Hmm, I can think of at least one downstream project that likes to use hessian_vector_product, maybe a compromise would be to re-implement this as a wrapper around make_hvp (not sure why I didn't already do that).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants