Skip to content

Fix Repository __getitem__ consistency with __contains__ #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix Repository __getitem__ consistency with __contains__ #180

wants to merge 1 commit into from

Conversation

sebPhilippot
Copy link

No description provided.

lucasrcezimbra
lucasrcezimbra requested changes Aug 25, 2025
View reviewed changes
Copy link
Member

@lucasrcezimbra lucasrcezimbra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are you trying to fix here? Can you explain and add test cases?

@sebPhilippot
Copy link
Author

The goal of my change (for issue #176) was to make the Repository classes consistent: if contains returns True because the key is present in os.environ, then getitem should also read from os.environ.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasrcezimbra lucasrcezimbra lucasrcezimbra requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sebPhilippot @lucasrcezimbra