Skip to content

Conversation

@simonbowly
Copy link
Member

@simonbowly simonbowly commented Oct 20, 2023

Todo:

  • Update API docs to add new 'acpolar' formulation
  • Mention in documentation / show example

@simonbowly simonbowly added this to the 1.2.0 release milestone Oct 20, 2023
@simonbowly simonbowly self-assigned this Oct 20, 2023
@simonbowly simonbowly removed this from the 1.2.0 release milestone Nov 8, 2023
@pobonomo
Copy link
Member

Two years after it is finally time to merge this! 🥳

@hhijazi and/or @JaromilNajman can you double check it and convince @simonbowly it is a must have please?

simonbowly added a commit to simonbowly/gurobi-optimods that referenced this pull request Oct 19, 2025
simonbowly added a commit to simonbowly/gurobi-optimods that referenced this pull request Oct 19, 2025
@simonbowly simonbowly marked this pull request as ready for review October 19, 2025 12:14
@simonbowly
Copy link
Member Author

Woohoo, it's time!?

We should also take a look at the parameter settings for the other model types. I'm guessing for aclocal with v13 we'll want OptimalityTarget=1, and maybe we don't need the relaxed MIP gaps anymore?

@pobonomo
Copy link
Member

Yes good point. We should probably revise all possibilities in view of v13. Pinging the ACOPF gurus @hhijazi and @JaromilNajman

useef = True
usejabr = False
polar = False
default_solver_params = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would change the settings to

"OptimalityTarget": 1
"SolutionLimit": 1

We have to set a solution limit for the case when we have branch switching, because then we have binaries in the model.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wouldn't OptimalityTarget 1 throw an error for a MIP?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, it would. We would need to do something else when we have branch switching on.


# use aclocal to run Gurobi as a local solver (stops at the first feasible solution)
if opftype.lower() == "aclocal":
opftype = "ac"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would remove aclocal and introduce acreclocal and acpolarlocal which are the same, but with the difference that for rec we use

        useef = True
        usejabr = False
        polar = False

and for polar we use

        useef = False
        usejabr = False
        polar = True

@JaromilNajman
Copy link
Contributor

We need to adjust the polar formulation to use nlconstrs. Right now it still manually disaggregates the model and uses addGenConstrSin and Cos.

hhijazi added a commit to hhijazi/gurobi-optimods that referenced this pull request Oct 27, 2025
, solver parameters, and unit tests
hhijazi added a commit to hhijazi/gurobi-optimods that referenced this pull request Oct 28, 2025
@hhijazi
Copy link
Member

hhijazi commented Oct 29, 2025

Can we close this one and transition to #176?
@JaromilNajman I'm done with the code changes, do you mind taking care of the API doc/example tasks?

@simonbowly simonbowly closed this Oct 30, 2025
@JaromilNajman
Copy link
Contributor

JaromilNajman commented Oct 30, 2025

I'm done with the code changes, do you mind taking care of the API doc/example tasks?

I can do that. What exactly is left to be done?

EDIT: I think I know now what has to be done.

hhijazi added a commit to hhijazi/gurobi-optimods that referenced this pull request Nov 7, 2025
hhijazi added a commit to hhijazi/gurobi-optimods that referenced this pull request Nov 7, 2025
hhijazi added a commit to hhijazi/gurobi-optimods that referenced this pull request Nov 7, 2025
hhijazi added a commit to hhijazi/gurobi-optimods that referenced this pull request Nov 8, 2025
hhijazi added a commit to hhijazi/gurobi-optimods that referenced this pull request Nov 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants