Skip to content

Conversation

@KMohZaid
Copy link

@KMohZaid KMohZaid commented Jun 19, 2025

…able, allow them to force join with warning

Resolves #661

cherry picked from messed up PR (#660 (comment))

NOTE :

  1. There are places where i used english string, which i thing we can move to .xml file and add support for translation
  2. For testing player name validator, uncomment function call in Werewolf Control/Program.cs Main method

name validator working screenshots are sent in "Grey Wolf Support" group : https://t.me/c/1060486754/788569

TODO :

  • Move hardcoded message to XML file for translation support

@Olgabrezel
Copy link
Collaborator

I don't think Werewolf needs this.
What makes a name "readable" is subjective and depends on

  • the language and characters being used (e.g. a name in Arabic letters is readable in the context of an Arabic group, but unreadable in the context of an English group),
  • the culture (an emoji-only name could be "readable" but it could also be "unreadable" depending on the exact name. Or maybe it is even desired, for a group that uses the Emoji language pack),
  • other factors such as the length and pronouncability of the name (I would argue P is a more valid name than JNFREIKJFNOAEDJFNIEWRJGNRIJVOISEFNEWIUFNSI)
  • and, last but not least: the group's rules and its admins' discretion.

There is no one pattern that defines a valid name, so it's something that group admins will need to take care of.
Besides, this force-join mechanic basically invalidates the setting because group admins' manual intervention is still required when someone breaks the name conventions.
And the fact that it's not /config-urable but just enabled for all groups is also not desirable.

So sorry, but I will close this PR.

@Olgabrezel Olgabrezel closed this Jun 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants