Skip to content

Fixing Notice: Undefined index: titles #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixing Notice: Undefined index: titles #41

wants to merge 1 commit into from

Conversation

@emulienfou
Copy link

In some cases, a PHP notice is returned because the array key titles doesn't exists like:

Error: Method Gregwar\RST\HTML\Document::__toString() must not throw an exception, caught ErrorException: Notice: Undefined index: titles

Fixing this issue by returning an empty array.

jwage
jwage approved these changes Apr 7, 2018
View reviewed changes
Copy link

@jwage jwage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I have the same notice when building.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jwage jwage jwage approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@emulienfou @jwage