initial support for blocking media autoplay #235
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thestinger
force-pushed
the
13
branch
2 times, most recently
from
7d82a65 to
451a394
Compare
|
Update on autoplay policy: I split the functionality into three patches:
Current autoplay policy (if autoplay is blocked for site as per content settings):
|
|
@octocorvus needs to be rebased again |
octocorvus
force-pushed
the
autoplay
branch
2 times, most recently
from
6f3dccd to
ba0da90
Compare
... when not allowed by content settings. This commit adds four patches: 1. Add enable-autoplay-permssion flag to the renderer. 2. Implement experimental Autoplay site setting (behind a flag). 3. Add AllowAutoplay in WebContentSettingsClient (allows accessing the Autoplay setting in the renderer (blink). 4. Implement the below autoplay policy. Current autoplay policy (if autoplay is blocked for site as per content settings): 1. Muted autoplay is always blocked. 2. Autoplay with sound is allowed if and only if the user has interacted with domain (click, tap, etc.). If we block this, then the user won't be able to start a video by tapping on the play button, since those will be blocked too.
thestinger
force-pushed
the
main
branch
5 times, most recently
from
aba674c to
fa13acc
Compare
thestinger
force-pushed
the
main
branch
3 times, most recently
from
579e3d3 to
4caf62a
Compare
thestinger
force-pushed
the
main
branch
3 times, most recently
from
8b72e2f to
2ffe602
Compare
thestinger
force-pushed
the
main
branch
2 times, most recently
from
472f033 to
b206e18
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a setting to
chrome://flagsto block media autoplay. Issue #92Tested on a real device running Android 13 (GrapheneOS). Working as exepected (details below) on most websites. But in my testing I found that when navigating on the same website (same-origin), autoplay is not always blocked (yet to figure out how to block that). Also, I'm not sure if this is the only case where autoplay is not blocked; it needs more testing.
I'll make a UI for this later (once this feature is ready).
How it works:
See autoplay flowchart. If the feature/flag
kBlockMediaAutoplayis enabled,AutoplayPolicywill block any attempts to:play()on the media elementsetMuted(false)(I'm not sure if this needs to be done, since autoplay is already blocked)