implement precedence and adds tests for correctness #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(tests has not been updated yet) |
also adds many more tests. fixed some bugs; some cases output is now cleaner
Alan-Chen99
changed the title
|
@GrandMoff100 Fixed pylint errors, please review |
|
This is a huge PR lol Please split it up into easily reviewable small ones (~50ish additions/deletions max) |
|
Otherwise your changes might be more suitable for a library of your own. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
attempts to assign a precedence to each combinator.
generates some redundant parenthesis, but fixes some bugs.