-
Notifications
You must be signed in to change notification settings - Fork 124
fix: Issue 1497 generate partitions custom query #1500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
sundar-mudupalli-work
merged 10 commits into
develop
from
issue-1497-generate-partitions-custom-query
Apr 16, 2025
Merged
fix: Issue 1497 generate partitions custom query #1500
sundar-mudupalli-work
merged 10 commits into
develop
from
issue-1497-generate-partitions-custom-query
Apr 16, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/gcbrun |
/gcbrun |
This was referenced Apr 11, 2025
nj1973
requested changes
Apr 11, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly nit pick comments.
/gcbrun |
/gcbrun |
nj1973
approved these changes
Apr 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
These changes fix a number of issues, standardize the generate partitions tests across the different engines and have some minor cleanup.
Generate Partition tests
In order to not break prior builds, a new table
pso_data_validator.test_generate_partitions_v2
was created on all engines. In nearly every engine a composite key consisting of string, integer, timestamp, date and boolean value is used to generate partitions. There are issues with engines including Impala and MS SQL Server, MySQL, Oracle, and TeradataCleanup
util.py
Issues to be closed
1497 Generate Partitions With (complex) custom query
1183 generate table partitions replaces whitespace in primary keys with a single space.
923 generate-table-partitions generates invalid SQL in filter clause when a timestamp field is part of the primary-key
Checklist
CONTRIBUTING
Guide.tests/local_check.sh
script)