Skip to content

Add option to provide custom XPK branch #672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 15, 2025
Merged

Add option to provide custom XPK branch #672

merged 1 commit into from
Apr 15, 2025

Conversation

abhinavclemson
Copy link
Collaborator

Description

Add option to provide custom XPK branch.

  • Currently, XPK new version release interval is 2-3 weeks, it causes a long turn around period.

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run one-shot tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed.

RissyRan
RissyRan reviewed Apr 14, 2025
View reviewed changes
RissyRan
RissyRan reviewed Apr 14, 2025
View reviewed changes
Copy link
Collaborator

@RissyRan RissyRan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this! Just one comment.

@abhinavclemson abhinavclemson force-pushed the xpk-abhi branch 4 times, most recently from 7d2ed22 to af36566 Compare April 15, 2025 16:32
@abhinavclemson abhinavclemson requested a review from RissyRan April 15, 2025 16:34
RissyRan
RissyRan reviewed Apr 15, 2025
View reviewed changes
@abhinavclemson abhinavclemson force-pushed the xpk-abhi branch 5 times, most recently from 91fff3a to 311b35d Compare April 15, 2025 19:19
@abhinavclemson abhinavclemson requested a review from RissyRan April 15, 2025 19:30
RissyRan
RissyRan approved these changes Apr 15, 2025
View reviewed changes
Copy link
Collaborator

@RissyRan RissyRan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@abhinavclemson abhinavclemson merged commit 85525ce into master Apr 15, 2025
6 checks passed
@abhinavclemson abhinavclemson deleted the xpk-abhi branch April 15, 2025 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RissyRan RissyRan RissyRan approved these changes

@richardsliu richardsliu Awaiting requested review from richardsliu richardsliu is a code owner

@yixinshi yixinshi Awaiting requested review from yixinshi yixinshi is a code owner

@hyeygit hyeygit Awaiting requested review from hyeygit hyeygit is a code owner

Assignees

@RissyRan RissyRan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abhinavclemson @RissyRan