Skip to content

Add a consumer label upsert functionality to the mpdev tf overwrite command #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 15, 2025
Merged

Add a consumer label upsert functionality to the mpdev tf overwrite command #93

merged 5 commits into from
Apr 15, 2025

Conversation

nrgoogle
Copy link
Contributor

  • Improved error output for test runs and fixed test warnings by adding the size attributes.
  • Introduced a method to upsert a consumer label into the TF config

@skywardpixel
Copy link
Contributor

/gcbrun

@kaiyangg kaiyangg marked this pull request as ready for review April 14, 2025 20:36
kaiyangg
kaiyangg approved these changes Apr 14, 2025
View reviewed changes
Copy link
Contributor

@kaiyangg kaiyangg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

skywardpixel
skywardpixel reviewed Apr 14, 2025
View reviewed changes
@skywardpixel
Copy link
Contributor

/gcbrun

@nrgoogle
Copy link
Contributor Author

/gcbrun

@nrgoogle nrgoogle requested a review from skywardpixel April 15, 2025 20:08
@nrgoogle nrgoogle merged commit cd92f93 into master Apr 15, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaiyangg kaiyangg kaiyangg approved these changes

@skywardpixel skywardpixel Awaiting requested review from skywardpixel

Assignees

@skywardpixel skywardpixel

@kaiyangg kaiyangg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nrgoogle @skywardpixel @kaiyangg