Skip to content

Add cloud run service to iap iam policy #13688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 17, 2025
Merged

Add cloud run service to iap iam policy #13688

merged 4 commits into from
Apr 17, 2025
+56 −0

Conversation

bryan0515
Copy link
Contributor

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

`google_iap_web_cloud_run_service_iam_policy`

`google_iap_web_cloud_run_service_iam_binding`

`google_iap_web_cloud_run_service_iam_member`

@github-actions github-actions bot requested a review from NickElliot April 15, 2025 23:37
@github-actions GitHub Actions
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: see go/terraform-auto-test-runs to set up automatic test runs.

@NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 1308 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 1308 insertions(+), 2 deletions(-))

Missing doc report (experimental)

The following resources have fields missing in documents.

  • google_iap_web_cloud_run_service_iam_binding
    • Expected Document Path: /website/docs/r/iap_web_cloud_run_service_iam.html.markdown
    • Fields: [region]
  • google_iap_web_cloud_run_service_iam_member
    • Expected Document Path: /website/docs/r/iap_web_cloud_run_service_iam.html.markdown
    • Fields: [region]
  • google_iap_web_cloud_run_service_iam_policy
    • Expected Document Path: /website/docs/r/iap_web_cloud_run_service_iam.html.markdown
    • Fields: [region]

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 87
Passed tests: 61
Skipped tests: 20
Affected tests: 6

Click here to see the affected service packages
  • iap
#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccIapWebCloudRunServiceIamBindingGenerated_withAndWithoutCondition
  • TestAccIapWebCloudRunServiceIamMemberGenerated_withAndWithoutCondition

Action taken

Found 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccIapWebCloudRunServiceIamBindingGenerated
  • TestAccIapWebCloudRunServiceIamBindingGenerated_withCondition
  • TestAccIapWebCloudRunServiceIamMemberGenerated
  • TestAccIapWebCloudRunServiceIamMemberGenerated_withCondition
  • TestAccIapWebCloudRunServiceIamPolicyGenerated
  • TestAccIapWebCloudRunServiceIamPolicyGenerated_withCondition

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccIapWebCloudRunServiceIamBindingGenerated [Error message] [Debug log]
TestAccIapWebCloudRunServiceIamBindingGenerated_withCondition [Error message] [Debug log]
TestAccIapWebCloudRunServiceIamMemberGenerated [Error message] [Debug log]
TestAccIapWebCloudRunServiceIamMemberGenerated_withCondition [Error message] [Debug log]
TestAccIapWebCloudRunServiceIamPolicyGenerated [Error message] [Debug log]
TestAccIapWebCloudRunServiceIamPolicyGenerated_withCondition [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 1227 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 1227 insertions(+), 2 deletions(-))

Missing doc report (experimental)

The following resources have fields missing in documents.

  • google_iap_web_cloud_run_service_iam_binding
    • Expected Document Path: /website/docs/r/iap_web_cloud_run_service_iam.html.markdown
    • Fields: [location]
  • google_iap_web_cloud_run_service_iam_member
    • Expected Document Path: /website/docs/r/iap_web_cloud_run_service_iam.html.markdown
    • Fields: [location]
  • google_iap_web_cloud_run_service_iam_policy
    • Expected Document Path: /website/docs/r/iap_web_cloud_run_service_iam.html.markdown
    • Fields: [location]

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 87
Passed tests: 61
Skipped tests: 20
Affected tests: 6

Click here to see the affected service packages
  • iap
#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccIapWebCloudRunServiceIamBindingGenerated_withAndWithoutCondition
  • TestAccIapWebCloudRunServiceIamMemberGenerated_withAndWithoutCondition

Action taken

Found 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccIapWebCloudRunServiceIamBindingGenerated
  • TestAccIapWebCloudRunServiceIamBindingGenerated_withCondition
  • TestAccIapWebCloudRunServiceIamMemberGenerated
  • TestAccIapWebCloudRunServiceIamMemberGenerated_withCondition
  • TestAccIapWebCloudRunServiceIamPolicyGenerated
  • TestAccIapWebCloudRunServiceIamPolicyGenerated_withCondition

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccIapWebCloudRunServiceIamBindingGenerated [Error message] [Debug log]
TestAccIapWebCloudRunServiceIamBindingGenerated_withCondition [Error message] [Debug log]
TestAccIapWebCloudRunServiceIamMemberGenerated [Error message] [Debug log]
TestAccIapWebCloudRunServiceIamMemberGenerated_withCondition [Error message] [Debug log]
TestAccIapWebCloudRunServiceIamPolicyGenerated [Error message] [Debug log]
TestAccIapWebCloudRunServiceIamPolicyGenerated_withCondition [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@bryan0515
Copy link
Contributor Author

@NickElliot Would you mind help me take a look at this issue? It seems to work with existing resources, but failed for new ones. I'm not sure why the id is not generating properly.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 1228 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 1228 insertions(+), 2 deletions(-))

Missing doc report (experimental)

The following resources have fields missing in documents.

  • google_iap_web_cloud_run_service_iam_binding
    • Expected Document Path: /website/docs/r/iap_web_cloud_run_service_iam.html.markdown
    • Fields: [location]
  • google_iap_web_cloud_run_service_iam_member
    • Expected Document Path: /website/docs/r/iap_web_cloud_run_service_iam.html.markdown
    • Fields: [location]
  • google_iap_web_cloud_run_service_iam_policy
    • Expected Document Path: /website/docs/r/iap_web_cloud_run_service_iam.html.markdown
    • Fields: [location]

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 87
Passed tests: 61
Skipped tests: 20
Affected tests: 6

Click here to see the affected service packages
  • iap
#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccIapWebCloudRunServiceIamBindingGenerated_withAndWithoutCondition
  • TestAccIapWebCloudRunServiceIamMemberGenerated_withAndWithoutCondition

Action taken

Found 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccIapWebCloudRunServiceIamBindingGenerated
  • TestAccIapWebCloudRunServiceIamBindingGenerated_withCondition
  • TestAccIapWebCloudRunServiceIamMemberGenerated
  • TestAccIapWebCloudRunServiceIamMemberGenerated_withCondition
  • TestAccIapWebCloudRunServiceIamPolicyGenerated
  • TestAccIapWebCloudRunServiceIamPolicyGenerated_withCondition

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccIapWebCloudRunServiceIamBindingGenerated [Debug log]
TestAccIapWebCloudRunServiceIamBindingGenerated_withCondition [Debug log]
TestAccIapWebCloudRunServiceIamMemberGenerated [Debug log]
TestAccIapWebCloudRunServiceIamMemberGenerated_withCondition [Debug log]
TestAccIapWebCloudRunServiceIamPolicyGenerated [Debug log]
TestAccIapWebCloudRunServiceIamPolicyGenerated_withCondition [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🟢 All tests passed!

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 1234 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 1234 insertions(+), 2 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 87
Passed tests: 67
Skipped tests: 20
Affected tests: 0

Click here to see the affected service packages
  • iap
#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccIapWebCloudRunServiceIamBindingGenerated_withAndWithoutCondition
  • TestAccIapWebCloudRunServiceIamMemberGenerated_withAndWithoutCondition
    🟢 All tests passed!

View the build log

NickElliot
NickElliot reviewed Apr 17, 2025
View reviewed changes
Copy link
Contributor

@NickElliot NickElliot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you ran the tests for this locally to verify it works as expected?

NickElliot
NickElliot approved these changes Apr 17, 2025
View reviewed changes
Copy link
Contributor

@NickElliot NickElliot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

disregard, LGTM

@NickElliot NickElliot added this pull request to the merge queue Apr 17, 2025
Merged via the queue into GoogleCloudPlatform:main with commit 0f3fb02 Apr 17, 2025
22 checks passed
This was referenced Apr 17, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickElliot NickElliot NickElliot approved these changes

Assignees
No one assigned
Labels
service/iap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bryan0515 @modular-magician @NickElliot