Skip to content

Made opasync set computed idformat fields if required instead of identity fields #13686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

melinath
Copy link
Member

This is a follow-up to #13619 (and part of hashicorp/terraform-provider-google#22214). It makes resources automatically set fields from id_format instead of using the concept of "identity" fields. This involves switching them over to using the function introduced in #13619 (which is also used by pollasync and non-async Create behavior.)

The follow resources needed additional special attention:

  • spanner database. post_create relied specifically on accessing opRes, but name is not actually a computed field on that resource so after this change opRes is no longer set. Changed to read name from res instead.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


@modular-magician

This comment was marked as outdated.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 162 files changed, 796 insertions(+), 2448 deletions(-))
google-beta provider: Diff ( 182 files changed, 906 insertions(+), 2742 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1496
Passed tests: 1329
Skipped tests: 162
Affected tests: 5

Click here to see the affected service packages
  • artifactregistry
  • managedkafka
  • memcache
  • resourcemanager
  • vertexai
  • discoveryengine
  • logging
  • osconfigv2
  • tpuv2
  • firebase
  • looker
  • notebooks
  • spanner
  • activedirectory
  • blockchainnodeengine
  • firestore
  • tpu
  • apphub
  • cloudids
  • developerconnect
  • tags
  • gemini
  • iam3
  • parallelstore
  • apihub
  • cloudbuild
  • cloudfunctions2
  • datastream
  • apigateway
  • dialogflowcx
  • workbench
  • workflows
  • firebaseapphosting
  • gkehub2
  • memorystore
  • migrationcenter
  • lustre
  • appengine
  • beyondcorp
  • filestore
  • firebaseextensions
  • privateca
  • accesscontextmanager
  • apigee
  • datacatalog
  • kms
  • storage
  • vpcaccess
  • cloudrunv2
  • datafusion
  • healthcare
  • privilegedaccessmanager
  • gkeonprem
  • integrationconnectors
  • serviceusage
  • backupdr
  • chronicle
  • containerattached
  • gkebackup
  • networkmanagement
  • networksecurity
  • oracledatabase
  • bigqueryreservation
  • eventarc
  • firebasedataconnect
  • gkehub

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccLoggingFolderSettings_update
  • TestAccCloudbuildWorkerPool_basic
  • TestAccDataSourceGoogleGkeHubFeature_basic
  • TestAccAccessContextManager
  • TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccAccessContextManager [Debug log]
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]
TestAccLoggingFolderSettings_update [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccAccessContextManager [Error message] [Debug log]
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.


🔴 Tests failed during RECORDING mode:
TestAccCloudbuildWorkerPool_basic [Error message] [Debug log]
TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants