Add TF support for data-cache-count for GKE Data Cache

[halimsam]

Add terraform support for data_cache_count on cluster/nodepool create.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

container: added `data_cache_count` to `ephemeral_storage_local_ssd_config` for `google_container_node_pool`

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: see go/terraform-auto-test-runs to set up automatic test runs.

@roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 134 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 3 files changed, 134 insertions(+), 1 deletion(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_container_cluster (451 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_container_cluster" "primary" {
  node_config {
    ephemeral_storage_local_ssd_config {
      data_cache_count = # value needed
    }
  }
  node_pool {
    node_config {
      ephemeral_storage_local_ssd_config {
        data_cache_count = # value needed
      }
    }
  }
}

Missing doc report (experimental)

The following resources have fields missing in documents.

• google_container_cluster
  • Expected Document Path: /website/docs/r/container_cluster.html.markdown
  • Fields: [node_pool.node_config.ephemeral_storage_local_ssd_config.data_cache_count]
• google_container_node_pool
  • Expected Document Path: /website/docs/r/container_node_pool.html.markdown
  • Fields: [node_config.ephemeral_storage_local_ssd_config.data_cache_count]

[modular-magician]

Tests analytics

Total tests: 232
Passed tests: 219
Skipped tests: 11
Affected tests: 2

Click here to see the affected service packages

• container

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccContainerNodePool_ephemeralStorageLocalSsdConfigOnlyDataCacheCount
• TestAccContainerNodePool_ephemeralStorageLocalSsdConfigWithDataCacheCount

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccContainerNodePool_ephemeralStorageLocalSsdConfigWithDataCacheCount [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🔴 Tests failed during RECORDING mode:
TestAccContainerNodePool_ephemeralStorageLocalSsdConfigOnlyDataCacheCount [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 135 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 3 files changed, 135 insertions(+), 1 deletion(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_container_cluster (451 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_container_cluster" "primary" {
  node_config {
    ephemeral_storage_local_ssd_config {
      data_cache_count = # value needed
    }
  }
  node_pool {
    node_config {
      ephemeral_storage_local_ssd_config {
        data_cache_count = # value needed
      }
    }
  }
}

Missing doc report (experimental)

The following resources have fields missing in documents.

• google_container_cluster
  • Expected Document Path: /website/docs/r/container_cluster.html.markdown
  • Fields: [node_pool.node_config.ephemeral_storage_local_ssd_config.data_cache_count]
• google_container_node_pool
  • Expected Document Path: /website/docs/r/container_node_pool.html.markdown
  • Fields: [node_config.ephemeral_storage_local_ssd_config.data_cache_count]

[modular-magician]

Tests analytics

Total tests: 232
Passed tests: 220
Skipped tests: 11
Affected tests: 1

Click here to see the affected service packages

• container

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccContainerNodePool_ephemeralStorageLocalSsdConfigOnlyDataCacheCount

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccContainerNodePool_ephemeralStorageLocalSsdConfigOnlyDataCacheCount [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test

[sunnylovestiramisu]

/lgtm

[github-actions]

@roaks3 This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 134 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 3 files changed, 134 insertions(+), 1 deletion(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_container_cluster (451 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_container_cluster" "primary" {
  node_config {
    ephemeral_storage_local_ssd_config {
      data_cache_count = # value needed
    }
  }
  node_pool {
    node_config {
      ephemeral_storage_local_ssd_config {
        data_cache_count = # value needed
      }
    }
  }
}

Missing doc report (experimental)

The following resources have fields missing in documents.

• google_container_cluster
  • Expected Document Path: /website/docs/r/container_cluster.html.markdown
  • Fields: [node_pool.node_config.ephemeral_storage_local_ssd_config.data_cache_count]
• google_container_node_pool
  • Expected Document Path: /website/docs/r/container_node_pool.html.markdown
  • Fields: [node_config.ephemeral_storage_local_ssd_config.data_cache_count]

[modular-magician]

Tests analytics

Total tests: 232
Passed tests: 221
Skipped tests: 11
Affected tests: 0

Click here to see the affected service packages

• container

🟢 All tests passed!

View the build log

[halimsam]

@roaks3 Wanted to get a followup if there are any updates on review for this PR? Thank you!

[github-actions]

@GoogleCloudPlatform/terraform-team @roaks3 This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

[roaks3]

LGTM, sorry for the delay on this!