Skip to content

Fix for #13677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fix for #13677

wants to merge 4 commits into from

Conversation

NA2047
Copy link
Contributor

@NA2047 NA2047 commented Apr 15, 2025

Fix for Issue Issue 21775

google_compute_network_firewall_policy_rule:  Adding diffsuppress  for Issue 21775

@github-actions github-actions bot requested a review from SirGitsalot April 15, 2025 03:42
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: see go/terraform-auto-test-runs to set up automatic test runs.

@SirGitsalot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 42 insertions(+), 5 deletions(-))
google-beta provider: Diff ( 2 files changed, 42 insertions(+), 5 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 12 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1163
Passed tests: 1077
Skipped tests: 84
Affected tests: 2

Click here to see the affected service packages
  • compute

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeNetworkFirewallPolicyRule_securityProfileGroup_update
  • TestAccComputeNetworkFirewallSecurityProfileGroupDiffsuppress

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccComputeNetworkFirewallPolicyRule_securityProfileGroup_update [Error message] [Debug log]
TestAccComputeNetworkFirewallSecurityProfileGroupDiffsuppress [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@github-actions github-actions bot requested a review from SirGitsalot April 16, 2025 16:20
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 42 insertions(+), 5 deletions(-))
google-beta provider: Diff ( 2 files changed, 42 insertions(+), 5 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 13 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1169
Passed tests: 1083
Skipped tests: 84
Affected tests: 2

Click here to see the affected service packages
  • compute

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeNetworkFirewallSecurityProfileGroupDiffsuppress
  • TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🔴 Tests failed during RECORDING mode:
TestAccComputeNetworkFirewallSecurityProfileGroupDiffsuppress [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 44 insertions(+), 5 deletions(-))
google-beta provider: Diff ( 2 files changed, 44 insertions(+), 5 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 13 insertions(+))

1 similar comment
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 44 insertions(+), 5 deletions(-))
google-beta provider: Diff ( 2 files changed, 44 insertions(+), 5 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 13 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1169
Passed tests: 1084
Skipped tests: 84
Affected tests: 1

Click here to see the affected service packages
  • compute

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeNetworkFirewallSecurityProfileGroupDiffsuppress

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccComputeNetworkFirewallSecurityProfileGroupDiffsuppress [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1169
Passed tests: 1084
Skipped tests: 84
Affected tests: 1

Click here to see the affected service packages
  • compute

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeNetworkFirewallSecurityProfileGroupDiffsuppress

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccComputeNetworkFirewallSecurityProfileGroupDiffsuppress [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants